Skip to content

Support Scala 3 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2022
Merged

Support Scala 3 #39

merged 3 commits into from
Feb 2, 2022

Conversation

lolgab
Copy link
Collaborator

@lolgab lolgab commented Jan 23, 2022

No description provided.

@lolgab lolgab marked this pull request as ready for review January 23, 2022 23:01
@lolgab
Remove server which doesn't link on Scala 3
139d005 
- This server is superseded by SNUnit
This was referenced Feb 1, 2022
Merged
Merged
sideeffffect
sideeffffect reviewed Feb 1, 2022
View reviewed changes
@lolgab
Copy link
Collaborator Author

lolgab commented Feb 1, 2022

In the first commit I get:

[error] java.util.NoSuchElementException: key not found: Local(3)
[error] 	at scala.collection.MapLike.default(MapLike.scala:236)
[error] 	at scala.collection.MapLike.default$(MapLike.scala:235)
[error] 	at scala.collection.AbstractMap.default(Map.scala:65)
[error] 	at scala.collection.MapLike.apply(MapLike.scala:144)
[error] 	at scala.collection.MapLike.apply$(MapLike.scala:143)
[error] 	at scala.collection.AbstractMap.apply(Map.scala:65)
[error] 	at scala.scalanative.interflow.State.loadLocal(State.scala:119)
[error] 	at scala.scalanative.interflow.Eval.eval(Eval.scala:868)
[error] 	at scala.scalanative.interflow.Eval.eval$(Eval.scala:865)
[error] 	at scala.scalanative.interflow.Interflow.eval(Interflow.scala:10)
[error] 	at scala.scalanative.interflow.Eval.eval(Eval.scala:383)
[error] 	at scala.scalanative.interflow.Eval.eval$(Eval.scala:107)
[error] 	at scala.scalanative.interflow.Interflow.eval(Interflow.scala:10)
[error] 	at scala.scalanative.interflow.Eval.run(Eval.scala:30)
[error] 	at scala.scalanative.interflow.Eval.run$(Eval.scala:11)
[error] 	at scala.scalanative.interflow.Interflow.run(Interflow.scala:10)
[error] 	at scala.scalanative.interflow.MergeProcessor.visit(MergeProcessor.scala:376)
[error] 	at scala.scalanative.interflow.MergeProcessor.advance(MergeProcessor.scala:393)
[error] 	at scala.scalanative.interflow.Opt.process(Opt.scala:127)
[error] 	at scala.scalanative.interflow.Opt.process$(Opt.scala:111)
[error] 	at scala.scalanative.interflow.Interflow.process(Interflow.scala:10)
[error] 	at scala.scalanative.interflow.Inline.$anonfun$inline$1(Inline.scala:151)
[error] 	at scala.scalanative.interflow.Log.in(Log.scala:18)
[error] 	at scala.scalanative.interflow.Log.in$(Log.scala:8)
[error] 	at scala.scalanative.interflow.Interflow.in(Interflow.scala:10)
[error] 	at scala.scalanative.interflow.Inline.inline(Inline.scala:139)
[error] 	at scala.scalanative.interflow.Inline.inline$(Inline.scala:134)
[error] 	at scala.scalanative.interflow.Interflow.inline(Interflow.scala:10)
[error] 	at scala.scalanative.interflow.Eval.nonIntrinsic$1(Eval.scala:149)
[error] 	at scala.scalanative.interflow.Eval.eval(Eval.scala:163)
[error] 	at scala.scalanative.interflow.Eval.eval$(Eval.scala:107)
[error] 	at scala.scalanative.interflow.Interflow.eval(Interflow.scala:10)
[error] 	at scala.scalanative.interflow.Eval.run(Eval.scala:30)
[error] 	at scala.scalanative.interflow.Eval.run$(Eval.scala:11)
[error] 	at scala.scalanative.interflow.Interflow.run(Interflow.scala:10)
[error] 	at scala.scalanative.interflow.MergeProcessor.visit(MergeProcessor.scala:376)
[error] 	at scala.scalanative.interflow.MergeProcessor.advance(MergeProcessor.scala:393)
[error] 	at scala.scalanative.interflow.Opt.process(Opt.scala:127)
[error] 	at scala.scalanative.interflow.Opt.process$(Opt.scala:111)
[error] 	at scala.scalanative.interflow.Interflow.process(Interflow.scala:10)
[error] 	at scala.scalanative.interflow.Opt.$anonfun$opt$1(Opt.scala:74)
[error] 	at scala.scalanative.interflow.Log.in(Log.scala:18)
[error] 	at scala.scalanative.interflow.Log.in$(Log.scala:8)
[error] 	at scala.scalanative.interflow.Interflow.in(Interflow.scala:10)
[error] 	at scala.scalanative.interflow.Opt.opt(Opt.scala:22)
[error] 	at scala.scalanative.interflow.Opt.opt$(Opt.scala:22)
[error] 	at scala.scalanative.interflow.Interflow.opt(Interflow.scala:10)
[error] 	at scala.scalanative.interflow.Visit.visitMethod(Visit.scala:124)
[error] 	at scala.scalanative.interflow.Visit.visitMethod$(Visit.scala:117)
[error] 	at scala.scalanative.interflow.Interflow.visitMethod(Interflow.scala:10)
[error] 	at scala.scalanative.interflow.Visit.visit$1(Visit.scala:97)
[error] 	at scala.scalanative.interflow.Visit.$anonfun$visitLoop$1(Visit.scala:111)
[error] 	at scala.scalanative.interflow.Visit.$anonfun$visitLoop$1$adapted(Visit.scala:111)
[error] 	at scala.collection.parallel.mutable.ParArray$ParArrayIterator.foreach(ParArray.scala:145)
[error] 	at scala.collection.parallel.ParIterableLike$Foreach.leaf(ParIterableLike.scala:982)
[error] 	at scala.collection.parallel.Task.$anonfun$tryLeaf$1(Tasks.scala:53)
[error] 	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
[error] 	at scala.util.control.Breaks$$anon$1.catchBreak(Breaks.scala:67)
[error] 	at scala.collection.parallel.Task.tryLeaf(Tasks.scala:56)
[error] 	at scala.collection.parallel.Task.tryLeaf$(Tasks.scala:50)
[error] 	at scala.collection.parallel.ParIterableLike$Foreach.tryLeaf(ParIterableLike.scala:979)
[error] 	at scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.internal(Tasks.scala:160)
[error] 	at scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.internal$(Tasks.scala:157)
[error] 	at scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$WrappedTask.internal(Tasks.scala:440)
[error] 	at scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.compute(Tasks.scala:150)
[error] 	at scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.compute$(Tasks.scala:149)
[error] 	at scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$WrappedTask.compute(Tasks.scala:440)
[error] 	at java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:189)
[error] 	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
[error] 	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
[error] 	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
[error] 	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)
[error] (core / Test / nativeLink) java.util.NoSuchElementException: key not found: Local(3)
[error] Total time: 135 s (02:15), completed Jan 24, 2022 9:08:12 AM

Which I couldn't understand why it happens.
@WojciechMazur when you have time do you mind having a look?

@WojciechMazur
Copy link
Contributor

@lolgab I've seen some similar problems in the past but typically they're quite hard to debug. In most cases, these kinds of errors are caused by either incorrect merging of the state in the Interflow or when some code is incorrectly structured in NIR. I'll try to check it out today and would report when I would get some info.

@lolgab
Copy link
Collaborator Author

lolgab commented Feb 1, 2022 •
edited
Loading

@WojciechMazur I found a small reproduction for the error:

import scala.scalanative.unsafe._

object Main {
  type Func = CFuncPtr2[Ptr[Byte], Int, Unit]
  val func: Func = (handle: Ptr[Byte], i: Int) => ()
  def main(args: Array[String]): Unit = {}
}

It seems it happens when CFuncPtrs have both pointers and Ints

Opened an issue here: scala-native/scala-native#2550

@lolgab lolgab merged commit af3583c into master Feb 2, 2022
@lolgab lolgab deleted the support-scala-3 branch February 2, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideeffffect sideeffffect sideeffffect left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lolgab @WojciechMazur @sideeffffect
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy