Skip to content

feat(api-reference): show External Documentation Object #5623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 18, 2025

Conversation

hanspagel
Copy link
Member

@hanspagel hanspagel commented May 12, 2025

Problem

Currently, we don’t render External Documentation Objects. :(

Solution

This PR finally renders them. :)

Fixes #1020

Checklist

I’ve gone through the following:

  • I’ve added an explanation why this change is needed.
  • I’ve added a changeset (pnpm changeset).
  • I’ve added tests for the regression or new feature.
  • I’ve updated the documentation.

@hanspagel hanspagel self-assigned this May 12, 2025
Copy link

changeset-bot bot commented May 12, 2025

🦋 Changeset detected

Latest commit: ba45ba6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@scalar/types Patch
@scalar/themes Patch
@scalar/api-reference Patch
@scalar/docusaurus Patch
@scalar/nestjs-api-reference Patch
@scalar/nuxt Patch
@scalar/api-client-react Patch
@scalar/api-client Patch
@scalar/api-reference-react Patch
@scalar/core Patch
@scalar/nextjs-openapi Patch
@scalar/oas-utils Patch
@scalar/openapi-to-markdown Patch
@scalar/scripts Patch
@scalar/snippetz Patch
@scalar/workspace-store Patch
@scalar/components Patch
@scalar/use-codemirror Patch
scalar-app Patch
@scalar/aspire Patch
@scalar/aspnetcore Patch
@scalarapi/docker-api-reference Patch
@scalar/fastify-api-reference Patch
@scalar/nextjs-api-reference Patch
@scalar/express-api-reference Patch
@scalar/hono-api-reference Patch
@scalar/sveltekit Patch
@scalar/mock-server Patch
@scalar/postman-to-openapi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hanspagel hanspagel requested a review from cameronrohani May 12, 2025 15:10
@hanspagel hanspagel force-pushed the feat/external-docs branch from 1dfe985 to 3ecf352 Compare May 16, 2025 09:37
@hanspagel hanspagel assigned cameronrohani and unassigned hanspagel May 23, 2025
@antlio
Copy link
Contributor

antlio commented May 29, 2025

will jump into this once #5706 is in

@cameronrohani
Copy link
Contributor

@antlio can you get this one over the finish line?

just vertically stack these links in the introduction section:
image

and put at the top of endpoint / tag markdowns (but not in the same container as headings)
image

@antlio antlio force-pushed the feat/external-docs branch from 3ecf352 to 6263256 Compare June 11, 2025 08:51
@antlio antlio marked this pull request as ready for review June 11, 2025 08:51
Copy link

relativeci bot commented Jun 11, 2025

#11488 Bundle Size — 2.61MiB (+0.62%).

a747b1c(current) vs f62f7f3 main#11483(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#11488
     Baseline
#11483
Regression  Initial JS 2.61MiB(+0.62%) 2.59MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 100% 100%
No change  Chunks 1 1
No change  Assets 1 1
Change  Modules 1754(+0.75%) 1741
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 170 170
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#11488
     Baseline
#11483
Regression  JS 2.61MiB (+0.62%) 2.59MiB

Bundle analysis reportBranch feat/external-docsProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

github-actions bot commented Jun 11, 2025

@antlio antlio force-pushed the feat/external-docs branch 3 times, most recently from 60f5af0 to eb1bca6 Compare June 11, 2025 09:50
@marclave marclave self-requested a review June 11, 2025 13:54
Copy link
Member

@marclave marclave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we wanna use parsed spec anymore but waiting for @amritk

@antlio
Copy link
Contributor

antlio commented Jun 11, 2025

i don't think we wanna use parsed spec anymore but waiting for @amritk

fair i just lazily reused it since it is still heavily present, updated in order to favor store collection

@antlio antlio requested a review from marclave June 11, 2025 14:51
@antlio antlio force-pushed the feat/external-docs branch from 2e8ffaa to d43735a Compare June 11, 2025 15:13
@amritk
Copy link
Member

amritk commented Jun 11, 2025

Correct, I have removed it from there in my PR. use dreferencedDocument for now until we switch to new store

@amritk
Copy link
Member

amritk commented Jun 11, 2025

but you don't need to change anything in intro as I have already done it

@amritk amritk force-pushed the feat/external-docs branch from d43735a to cf26e10 Compare June 19, 2025 17:10
@hanspagel hanspagel force-pushed the feat/external-docs branch from cf26e10 to a19fa17 Compare June 20, 2025 09:21
@amritk
Copy link
Member

amritk commented Jun 20, 2025

on you now @marclave

@hanspagel hanspagel force-pushed the feat/external-docs branch from c4557cb to 90e1254 Compare June 23, 2025 13:40
@hanspagel hanspagel force-pushed the feat/external-docs branch from 8c93275 to 6ae4acf Compare July 18, 2025 07:44
Copy link
Contributor

@antlio antlio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slick!

@hanspagel hanspagel force-pushed the feat/external-docs branch from 3054b45 to 999ebca Compare July 18, 2025 08:01
@hanspagel hanspagel enabled auto-merge (squash) July 18, 2025 08:01
@hanspagel hanspagel force-pushed the feat/external-docs branch from 999ebca to ba45ba6 Compare July 18, 2025 08:10
@hanspagel hanspagel force-pushed the feat/external-docs branch from ba45ba6 to a747b1c Compare July 18, 2025 08:10
@hanspagel hanspagel merged commit fb62e1b into main Jul 18, 2025
38 checks passed
@hanspagel hanspagel deleted the feat/external-docs branch July 18, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Url of externalDocs property in info and tags
5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy