Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layer selection when coloring by values in a table #402

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

layer selection when coloring by values in a table #402

wants to merge 9 commits into from

Conversation

Sonja-Stockhaus
Copy link
Collaborator

Should solve #326

Plus: 2 bugfixes when coloring points by values in a table:
a) coloring by values in table.X didn't work before
b) Error when using the groups argument while the values to color by are stored in a table

@Sonja-Stockhaus Sonja-Stockhaus linked an issue Jan 7, 2025 that may be closed by this pull request
Cannot pass layer selection of anndata #326
Open
@Sonja-Stockhaus
Copy link
Collaborator Author

This PR depends on scverse/spatialdata#818

@Sonja-Stockhaus
Copy link
Collaborator Author

Sonja-Stockhaus commented Jan 7, 2025 •
edited
Loading

Todo:

  • Delete utils.get_values_point_table()? Fully use spatialdata's get_values()
  • Tests

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.97%. Comparing base (12f490d) to head (dfcacf1).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata_plot/pl/utils.py 77.77% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   83.76%   83.97%   +0.21%     
==========================================
  Files           8        8              
  Lines        1694     1704      +10     
==========================================
+ Hits         1419     1431      +12     
+ Misses        275      273       -2
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/basic.py 89.26% <ø> (ø)
src/spatialdata_plot/pl/render.py 91.16% <100.00%> (+0.38%) ⬆️
src/spatialdata_plot/pl/render_params.py 100.00% <100.00%> (ø)
src/spatialdata_plot/pl/utils.py 78.09% <77.77%> (+<0.01%) ⬆️

@Sonja-Stockhaus
Copy link
Collaborator Author

Sonja-Stockhaus commented Jan 14, 2025 •
edited
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtreis timtreis Awaiting requested review from timtreis

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot pass layer selection of anndata
2 participants
@Sonja-Stockhaus @codecov-commenter
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy