Revert clear_cache() for payload modifications (#4706)

In `Packet.add_payload()` and `remove_payload()`.
secdev · alxroyer-thales · Mar 21, 2025 · Mar 31, 2025 · Mar 31, 2025 · Apr 6, 2025
commit ead2e516212c2f29fac6547ed88eea07a61d75f0
diff --git a/scapy/packet.py b/scapy/packet.py
@@ -181,6 +181,7 @@ def __init__(self,
         #   Clarify the meaning for this `explicit` flag.
         #   Now that cache is cleared as soon as the packet is modified, possibly we could get rid of it?
         self.explicit = 0
+        #: Caches bytes after `dissect()` or `build()` for the current layer only (not the payload, even if set).
         self.raw_packet_cache = None  # type: Optional[bytes]
         self.wirelen = None  # type: Optional[int]
         self.direction = None  # type: Optional[int]
@@ -379,12 +380,12 @@ def get_field(self, fld):
         """DEV: returns the field instance from the name of the field"""
         return self.fieldtype[fld]
 
-    def add_payload(self, payload, clear_cache=True):
-        # type: (Union[Packet, bytes], bool) -> None
+    def add_payload(self, payload):
+        # type: (Union[Packet, bytes]) -> None
         if payload is None:
             return
         elif not isinstance(self.payload, NoPayload):
-            self.payload.add_payload(payload, clear_cache=clear_cache)
+            self.payload.add_payload(payload)
         else:
             if isinstance(payload, Packet):
                 self.payload = payload
@@ -398,19 +399,12 @@ def add_payload(self, payload, clear_cache=True):
             else:
                 raise TypeError("payload must be 'Packet', 'bytes', 'str', 'bytearray', or 'memoryview', not [%s]" % repr(payload))  # noqa: E501
 
-            # Invalidate cache when the packet has changed.
-            if clear_cache:
-                self.clear_cache(upwards=True, downwards=False)
-
     def remove_payload(self):
         # type: () -> None
         self.payload.remove_underlayer(self)
         self.payload = NoPayload()
         self.overloaded_fields = {}
 
-        # Invalidate cache when the packet has changed.
-        self.clear_cache(upwards=True, downwards=False)
-
     def add_underlayer(self, underlayer):
         # type: (Packet) -> None
         self.underlayer = underlayer
@@ -1203,7 +1197,7 @@ def do_dissect_payload(self, s):
             ):
                 # stop dissection here
                 p = conf.raw_layer(s, _internal=1, _underlayer=self)
-                self.add_payload(p, clear_cache=False)
+                self.add_payload(p)
                 return
             cls = self.guess_payload_class(s)
             try:
@@ -1226,7 +1220,7 @@ def do_dissect_payload(self, s):
                     if cls is not None:
                         raise
                 p = conf.raw_layer(s, _internal=1, _underlayer=self)
-            self.add_payload(p, clear_cache=False)
+            self.add_payload(p)
 
     def dissect(self, s):
         # type: (bytes) -> None