fix(www): update use-toast file extension in docs and fix component source fileName resolution #7324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `files` array in `Index` are now all objects, not strings. As such, the `typeof file === 'string'` condition is never satisfied and, in the example of toast, will never correctly resolve the `toaster.tsx` and `use-toast.ts` file names and default to `component.files[0]?.path` (`toast.tsx` in our example). Let's update this condition to check against `file.path` instead and return `.path` if a matching file name is found.
|
@a-jih is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #7320
Toastdocs to use the correct file extension foruse-toast.ts.rehype-component.tswhere the path provided byfileNameis not correctly resolved.toaster.tsxanduse-toast.tscomponent sources in manual installation documentation.Screenshots
With these changes, the documentation now displays the correct
Toastcomponent/hook files.