Reverts the 'ant' requirement from #3217 #3221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simsong
reviewed
Mar 10, 2025
Comment on lines
+222
to
227
| dnl BC - TODO - Add this to the enable Java section and uncomment below | ||
| AC_PATH_PROG([ANT], [ant], [no]) | ||
| if test "x$ANT" = "xno"; then | ||
| AC_MSG_ERROR([Apache Ant is required but was not found. Install Ant and try again.]) | ||
| fi | ||
| dnl if test "x$ANT" = "xno"; then | ||
| dnl AC_MSG_ERROR([Apache Ant is required but was not found. Install Ant and try again.]) | ||
| dnl fi | ||
| AC_SUBST(ANT) |
There was a problem hiding this comment.
We can remove this, but then one of the make clean targets is going to fail, because many of the things made by ant can only be cleaned by ant. So we will need to conditionalize the make clean as well.
There was a problem hiding this comment.
And this should be moved into the Java section then, which I will do.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ant should not be a requirement unless the user wants to build Java. Someone should edit what is now there. I only commented out the error.