Skip to content

Rewrite image cache so that all reads are block-aligned. #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

judsonp
Copy link

@judsonp judsonp commented Aug 7, 2012

Should fix issue #85.

@simsong
Copy link
Member

simsong commented Sep 5, 2024

@judsonp - Hi. This is super old. We apologize for not getting to it.
Can you fix the conflicts? If so, I can accept it.

@simsong
Copy link
Member

simsong commented Sep 6, 2024

Is this still relevant?

@simsong
Copy link
Member

simsong commented Sep 8, 2024

Hi. Please rebase, resolve conflicts, and make sure it passes all check. Thanks.

@simsong simsong marked this pull request as draft September 8, 2024 17:19
@judsonp
Copy link
Author

judsonp commented Sep 10, 2024

I don't know if this still relevant. I haven't been involved with this project for some time now.

@judsonp
Copy link
Author

judsonp commented Sep 10, 2024

I don't have a test case for this any more, and haven't for some time. Given how much the files have drifted, unless there is a particular motivation to resurrect this, I'm happy to just close it out.

@simsong
Copy link
Member

simsong commented Sep 10, 2024

I'm sorry nobody got this for 13 years. But because this is such a critical piece of code that could have far reaching impacts and other people seem to have no issue with it, I am just going to close it.

Sorry!

@judsonp
Copy link
Author

judsonp commented Sep 11, 2024

No problem. I no longer have a need for this, and I don't know if the issue or motivation still exists for SleuthKit in general.

@simsong
Copy link
Member

simsong commented Sep 11, 2024

What was the issue?

@judsonp
Copy link
Author

judsonp commented Sep 11, 2024

#85: We were running SleuthKit against raw disk devices (/dev/rdiskN) on Mac. Those devices require block-aligned reads, and in some circumstances, SleuthKit (at least in HFS+) would try to make reads that were not block-aligned.

@simsong
Copy link
Member

simsong commented Sep 11, 2024

Thanks. We have seen another PR that also addressed the issue of unaligned reads. I'm going to rename this PR and open it again. Thanks.

@simsong simsong changed the title Image cache rewrite Rewrite image cache so that all reads are block-aligned. Sep 11, 2024
@simsong simsong reopened this Sep 11, 2024
@judsonp
Copy link
Author

judsonp commented Sep 11, 2024

Which PR is that?

@simsong
Copy link
Member

simsong commented Sep 11, 2024

Which PR is that?

Several:

#1841
#1780
#2255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy