-
Notifications
You must be signed in to change notification settings - Fork 643
Rewrite image cache so that all reads are block-aligned. #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cache and all reads are block-aligned.
@judsonp - Hi. This is super old. We apologize for not getting to it. |
Is this still relevant? |
Hi. Please rebase, resolve conflicts, and make sure it passes all check. Thanks. |
I don't know if this still relevant. I haven't been involved with this project for some time now. |
I don't have a test case for this any more, and haven't for some time. Given how much the files have drifted, unless there is a particular motivation to resurrect this, I'm happy to just close it out. |
I'm sorry nobody got this for 13 years. But because this is such a critical piece of code that could have far reaching impacts and other people seem to have no issue with it, I am just going to close it. Sorry! |
No problem. I no longer have a need for this, and I don't know if the issue or motivation still exists for SleuthKit in general. |
What was the issue? |
#85: We were running SleuthKit against raw disk devices (/dev/rdiskN) on Mac. Those devices require block-aligned reads, and in some circumstances, SleuthKit (at least in HFS+) would try to make reads that were not block-aligned. |
Thanks. We have seen another PR that also addressed the issue of unaligned reads. I'm going to rename this PR and open it again. Thanks. |
Which PR is that? |
Should fix issue #85.