Skip to content

new property skip_alternatives for coretto-, openjdk-, #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dschlenk
Copy link
Contributor

openjdk_source-, openjdk_pkg- install resources

Description

Describe what this change achieves

Issues Resolved

List any existing issues this PR resolves

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

openjdk_source-, openjdk_pkg- install resources
@dschlenk dschlenk requested a review from a team as a code owner May 17, 2025 13:42
@damacus
Copy link
Member

damacus commented May 17, 2025

Got any more details about skip alternatives? I'm a bit out of touch with this bit of Java

@dschlenk
Copy link
Contributor Author

When using OS packages, they typically already set up the alternatives for you, and usually with followers (aka slaves in some versions of update-alternatives) instead of separate configurations for each binary. And if you then add configs for those followers, bad things happen. On suse, you get errors (which is why I removed some binaries from the list for that platform). On redhat, it doesn't error, but it sometimes creates a broken config where the file exists in /var/lib/alternatives but the symlinks aren't made. But not always! I haven't been able to figure out the exact conditions to reproduce it but definitely doesn't happen if you remove the follower from the Java config first.

The most correct thing to do would probably be to add followers to the java config instead of making separate items on the platforms where this is supported, but I think the choice made to do individual configs was to avoid having to maintain each platform's idiosyncrasies. So, the next best option imo is to allow users to skip the creation of the derived java_alternatives resources so they can use the OS package defaults or manage it themselves, either with their own java_alternatives resources or something else. (Since resources defined by another resource live in their own child context it's not trivial to just edit_resource etc to make changes or set the action to :nothing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy