Skip to content

BREAKING CHANGE: Remove shaded dependencies and use HttpClient interface #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 17, 2025
Merged

BREAKING CHANGE: Remove shaded dependencies and use HttpClient interface #219

merged 11 commits into from
Mar 17, 2025

Conversation

Abhi347
Copy link
Member

@Abhi347 Abhi347 commented Mar 12, 2025 •
edited
Loading

Breaking Change

Remove shading dependencies, so that build tools (maven, gradel, bazel etc) can take care of dependency resolutions easily.

This will require changing the imports from com.spotify.githubclient.shade.okhttp3.* to okhttp3.* for all the users. Additionally, you will need to add okhttp3 as a separate dependency.

Another breaking change would be to use interfaces for HttpClient, instead of directly relying on OkHttp client. This will allow usage of other HttpClients. I've kept the OkHttpClient implementation for backwards compatibility, but in the future can be provided as a separate dependency, in case the users do not want to use OkHttp at all.

@codecov Codecov
Copy link

codecov bot commented Mar 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.54910% with 127 lines in your changes missing coverage. Please review.

Project coverage is 77.46%. Comparing base (13c7a91) to head (c64c195).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...va/com/spotify/github/v3/clients/GitHubClient.java 73.63% 65 Missing and 12 partials ⚠️
...m/spotify/github/http/okhttp/OkHttpHttpClient.java 77.10% 17 Missing and 2 partials ⚠️
...spotify/github/http/okhttp/OkHttpHttpResponse.java 64.00% 5 Missing and 4 partials ⚠️
...in/java/com/spotify/github/tracing/NoopTracer.java 46.15% 7 Missing ⚠️
...m/spotify/github/v3/clients/PullRequestClient.java 66.66% 5 Missing and 2 partials ⚠️
...java/com/spotify/github/http/BaseHttpResponse.java 88.88% 0 Missing and 2 partials ⚠️
...in/java/com/spotify/github/tracing/BaseTracer.java 88.23% 2 Missing ⚠️
...hub/tracing/opentelemetry/OpenTelemetryTracer.java 33.33% 2 Missing ⚠️
...main/java/com/spotify/github/http/HttpRequest.java 88.88% 0 Missing and 1 partial ⚠️
...om/spotify/github/v3/clients/RepositoryClient.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
+ Coverage     76.89%   77.46%   +0.56%     
- Complexity      381      417      +36     
============================================
  Files            56       60       +4     
  Lines          1277     1367      +90     
  Branches         51       59       +8     
============================================
+ Hits            982     1059      +77     
- Misses          264      265       +1     
- Partials         31       43      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Abhi347
Abhi347 commented Mar 12, 2025
View reviewed changes
@Abhi347 Abhi347 changed the title BREAKING CHANGE: Remove shaded dependencies BREAKING CHANGE: Remove shaded dependencies and use HttpClient interface Mar 12, 2025
@Abhi347 Abhi347 force-pushed the breaking-change/remove-shading-http branch from d96606c to f736c36 Compare March 14, 2025 12:09
@Abhi347 Abhi347 marked this pull request as ready for review March 14, 2025 13:20
@Abhi347 Abhi347 enabled auto-merge (squash) March 17, 2025 15:31
@Abhi347 Abhi347 merged commit 9da3b88 into master Mar 17, 2025
4 of 5 checks passed
@Abhi347 Abhi347 deleted the breaking-change/remove-shading-http branch March 17, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisgranath dennisgranath dennisgranath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abhi347 @dennisgranath
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy