Skip to content

fix: Fix the int vs long issue in IssueClient methods #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

Abhi347
Copy link
Member

@Abhi347 Abhi347 commented Mar 18, 2025

Creates overloaded methods for both int and long ids in IssueClient and marks int ids as deprecated.

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.42%. Comparing base (07a7513) to head (6cb031c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ava/com/spotify/github/v3/clients/IssueClient.java 66.66% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #222      +/-   ##
============================================
- Coverage     77.46%   77.42%   -0.05%     
- Complexity      417      421       +4     
============================================
  Files            60       60              
  Lines          1367     1373       +6     
  Branches         59       59              
============================================
+ Hits           1059     1063       +4     
- Misses          265      267       +2     
  Partials         43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Abhi347 Abhi347 force-pushed the fix/fix-issue-client-numbers branch from 4bd6712 to 6cb031c Compare March 18, 2025 13:38
@Abhi347 Abhi347 marked this pull request as ready for review March 18, 2025 13:44
@Abhi347 Abhi347 merged commit cbcbbad into master Mar 18, 2025
3 of 5 checks passed
@Abhi347 Abhi347 deleted the fix/fix-issue-client-numbers branch March 18, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy