Add dataclass_metadata parameter to mapped_column and friends.
#12619
Conversation
This parameter is then passed to `dataclasses.field()` if mapped as a dataclass. Fixes: sqlalchemy#10674
|
Missing docstrings for new parameters, but I'd like feedback on the general approach. Maybe there's something I've forgotten? I'm not well versed in sqlalchemy internals. |
|
Seems like a great start thanks! |
|
can we target this for 2.1 or do you need this in a hurry? |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 9ea6a95 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change 9ea6a95: https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/6024 |
|
Michael Bayer (zzzeek) wrote: recheck want to see why this failed View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/6024 |
|
hi - if you're still working on this, need to run python tools/sync_test_files.py |
Description
Field.metadatain python dataclasses is an extension mechanism.It's used by some serialization libraries like
xsdataanddesert.See #10674 and this discussion for more context.
This PR adds the parameter
dataclass_metadatatomapped_column(),column_property(),composite(),relationship(),synonym(),deferred(), andquery_expressions.Updates nessescary property and mapping tests.
Adds a new test
DCTransformsTest.test_dataclass_metadata.The parameter name,
dataclass_metadata, was suggested in #10674.The name in
_AttributeOptions,dataclasses_dataclass_metadata, was chosen to match the other parameters, as well as what tests expect.Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!