Use glob patterns in muxing rules #1193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using a handcrafted logic to determine if it was an exact match or an extension match (sorry about that). This PR replaces it for glob patterns
JAORMX
approved these changes
Mar 3, 2025
danbarr
approved these changes
Mar 3, 2025
aponcedeleonch
added a commit
that referenced
this pull request
Mar 4, 2025
On #1193 we put in place code for using glob patterns in muxing. This PR also updates the DB entries
aponcedeleonch
added a commit
that referenced
this pull request
Mar 4, 2025
On #1193 we put in place code for using glob patterns in muxing. This PR also updates the DB entries
aponcedeleonch
added a commit
that referenced
this pull request
Mar 4, 2025
On #1193 we put in place code for using glob patterns in muxing. This PR also updates the DB entries
aponcedeleonch
added a commit
that referenced
this pull request
Mar 4, 2025
* Add a migration to update previous matchers to glob patterns On #1193 we put in place code for using glob patterns in muxing. This PR also updates the DB entries * change in concat function to older version * manually changed down revision on migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a handcrafted logic to determine if it was an exact match or an extension match (sorry about that).
This PR replaces it for glob patterns