Validate persona description is sufficiently different #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #1218 Check if the description for a new persona is different enough from the existing personas descriptions. This is done to correctly differentiate between personas
befb7b4 to
490e355
Compare
JAORMX
approved these changes
Mar 5, 2025
| ) | ||
| # If the distance is less than the threshold, the persona description is too similar | ||
| if persona_distance.distance < self._persona_diff_desc_threshold: | ||
| return False |
There was a problem hiding this comment.
How expensive is it to parallelize this?
There was a problem hiding this comment.
I tried 2 approaches to get the distances:
- Direct query to sqlite and get the distances
- Query to get all the personas, then use
numpymatrices operations to get the distance
The result of the experiment was that it didn't matter, both of them were practically onpar.
For this specific comparison for just checking the threshold probably makes no difference to parallelize it with matrices operations. I don't expect someone having 1000 different personas in their DB. If it happens then yes, we would need for optimization. Probably with a sensible amount of personas (<10) really makes no difference
There was a problem hiding this comment.
Let's take an extreme but not unreasonable example: 100 personas. Would we start seeing issues in this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1218
Check if the description for a new persona is different enough from the existing personas descriptions. This is done to correctly differentiate between personas