Skip to content

Polish errors and miscelaneous fixes for workspaces #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 20, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disregard output from adding workspace
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
  • Loading branch information
JAORMX committed Jan 20, 2025
commit 263ec0c9ca24c3fb19f9808b8786e38421d59ce9
5 changes: 2 additions & 3 deletions src/codegate/api/v1.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ async def create_workspace(request: v1_models.CreateWorkspaceRequest):
"""Create a new workspace."""
# Input validation is done in the model
try:
created = await wscrud.add_workspace(request.name)
_ = await wscrud.add_workspace(request.name)
except AlreadyExistsError:
raise HTTPException(status_code=409, detail="Workspace already exists")
except ValidationError:
Expand All @@ -69,8 +69,7 @@ async def create_workspace(request: v1_models.CreateWorkspaceRequest):
except Exception:
raise HTTPException(status_code=500, detail="Internal server error")

if created:
return v1_models.Workspace(name=created.name)
return v1_models.Workspace(name=request.name)


@v1.delete(
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy