Skip to content

Log request file with its remote address if available #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2022
Merged

Log request file with its remote address if available #112

merged 2 commits into from
May 24, 2022

Conversation

joseluisq
Copy link
Collaborator

@joseluisq joseluisq commented May 23, 2022 •
edited
Loading

Description

This PR adds a boolean option (--log-remote-address) to log incoming requests information along with its remote address if available using the info log level.

Log examples

2022-05-23T22:24:50.519540Z  INFO static_web_server::handler: incoming request: method=GET uri=/ remote_addr=192.168.1.126:57625
2022-05-23T22:25:26.516841Z  INFO static_web_server::handler: incoming request: method=GET uri=/favicon.ico remote_addr=192.168.1.126:57625

Related Issue

No

Motivation and Context

Feature request #111 and motivated by #77 discussion.

How Has This Been Tested?

static-web-server -a 0.0.0.0 -p 8080 -d docker/public/ -g info
# 2022-05-23T22:24:44.523057Z  INFO static_web_server::logger: logging level: info
# 2022-05-23T22:24:44.523856Z  INFO static_web_server::server: server bound to TCP socket 0.0.0.0:8080
# 2022-05-23T22:24:44.523962Z  INFO static_web_server::server: runtime worker threads: 4
# 2022-05-23T22:24:44.523989Z  INFO static_web_server::server: security headers: enabled=false
# 2022-05-23T22:24:44.524006Z  INFO static_web_server::server: auto compression: enabled=true
# 2022-05-23T22:24:44.524061Z  INFO static_web_server::server: directory listing: enabled=false
# 2022-05-23T22:24:44.524097Z  INFO static_web_server::server: directory listing order code: 6
# 2022-05-23T22:24:44.524133Z  INFO static_web_server::server: cache control headers: enabled=true
# 2022-05-23T22:24:44.524191Z  INFO static_web_server::server: basic authentication: enabled=false
# 2022-05-23T22:24:44.524210Z  INFO static_web_server::server: grace period before graceful shutdown: 0s
# 2022-05-23T22:24:44.524527Z  INFO Server::start_server{addr_str="0.0.0.0:8080" threads=4}: static_web_server::server: close time.busy=0.00ns time.idle=10.6µs
# 2022-05-23T22:24:44.524585Z  INFO static_web_server::server: listening on http://0.0.0.0:8080
# 2022-05-23T22:24:44.524614Z  INFO static_web_server::server: press ctrl+c to shut down the server
# 2022-05-23T22:24:50.519540Z  INFO static_web_server::handler: incoming request: method=GET uri=/ remote_addr=192.168.1.126:57625
# 2022-05-23T22:25:26.516841Z  INFO static_web_server::handler: incoming request: method=GET uri=/favicon.ico remote_addr=192.168.1.126:57625
# 2022-05-23T22:25:26.517787Z  WARN static_web_server::error_page: method=GET uri=/favicon.ico status=404 error="Not Found"

Screenshots (if appropriate):

No

@joseluisq
feat: log request file with its remote address if available
b0499df 
example:

static-web-server -a 0.0.0.0 -p 8080 -d docker/public/ -g info
2022-05-23T22:24:50.519540Z  INFO static_web_server::handler: incoming request: method=GET uri=/ remote_addr=192.168.1.126:57625
2022-05-23T22:25:26.516841Z  INFO static_web_server::handler: incoming request: method=GET uri=/favicon.ico remote_addr=192.168.1.126:57625

resolves #111
@joseluisq joseluisq self-assigned this May 23, 2022
@joseluisq joseluisq added enhancement New feature or request v2 v2 release labels May 23, 2022
@nicheath
Copy link

Awesome thanks! I will be putting this to use.

@joseluisq joseluisq merged commit b49395a into master May 24, 2022
@bors bors bot deleted the feature/remote_address_logging branch May 24, 2022 22:14
@joseluisq
Copy link
Collaborator Author

Released on v2.9.0.

@dctaf dctaf mentioned this pull request Jan 31, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joseluisq joseluisq

Labels
enhancement New feature or request v2 v2 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseluisq @nicheath
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy