-
Notifications
You must be signed in to change notification settings - Fork 3.3k
ENH: add grouping (letter display) for pairwise comparison - rebased #9493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hello @josef-pkt! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
k_letters = len(all_) | ||
letter = [] * k_letters | ||
for i in range(k_groups): | ||
ss = ''.join(alphabet[j] if i in set_j else ' ' for j, set_j in enumerate(all_)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for visualization it looks better if there is a space between letters
Parameters | ||
---------- | ||
edges : array_like, 2-D, or None | ||
array or list of lists with edges in rows and two. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfinished sentence?
Do we have unit tests for using array?
funny detail with current code When specifying the distance matrix, and a diagonal element is nonzero (1), then it does not form a clique with itself. No letter is assigned to group (if it also has nonzero distance to the other groups). Insufficient input validation? As aside: |
problem with pandas html in notebook
We need to add "-" for empty letter position, optionally (The above is from an adjusted version of the cylinder example where also Germany differs from rest.) sorted by mean:
|
It looks like relabeling integer indices is quite easy. e.g. change label of first two groups
I did not manage to get a linear algebra row permutation matrix to work. update
|
rebased version of PR, closes #3674
second commit uses unit test from previous PR, adjustments for unique ordering and labeling.