Skip to content

L4+ unify OTG and other patches #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 18, 2025
Merged

L4+ unify OTG and other patches #1233

merged 4 commits into from
May 18, 2025

Conversation

burrbull
Copy link
Member

Copy link

github-actions bot commented May 18, 2025

Memory map comparison

@usbalbin
Copy link
Member

usbalbin commented May 18, 2025

Was this change intended? https://github.com/stm32-rs/stm32-rs-mmaps/compare/pr-1233-843bc2f53cc674977a1192e038cf87929d5d1743#diff-a434e336e269a4b209bffab539db9b86b91b121d24a817939a1d1eaa2e135b35R7147

- 0x50000104 B  REGISTER DIEPTXF1 (rw): OTG_FS device IN endpoint transmit FIFO size register (OTG_FS_DIEPTXF2)
+ 0x50000104 B  REGISTER DIEPTXF1 (rw): OTF_FS device IN endpoint transmit FIFO size register

OTG_FS vs OTF_FS

@@ -0,0 +1,272 @@
GOTGCTL:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to rm0432, some of these fields should be read only. Should that be specified here?

Copy link
Member

@usbalbin usbalbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@burrbull burrbull added this pull request to the merge queue May 18, 2025
Merged via the queue into master with commit 3d54137 May 18, 2025
24 checks passed
@burrbull burrbull deleted the newotg branch May 18, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy