-
Notifications
You must be signed in to change notification settings - Fork 243
WWDG prescaler fix for H7 #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ah, looks like it's edit: Also, it can be WWDG or WWDG1 or WWDG2, so better use the same selector as the g4 patch to catch them all. |
Ah, I should have caught that. The G4 doesn't have a patch for this, so I guess the SVD was already correct in that regard. |
db3f28e
to
0193f3d
Compare
Strange... The original svd file says this: ...
<peripheral>
<name>WWDG</name>
<description>WWDG</description>
<groupName>WWDG</groupName>
<baseAddress>0x50003000</baseAddress>
<addressBlock>
<offset>0x0</offset>
<size>0x400</size>
<usage>registers</usage>
</addressBlock>
... Is it renamed somewhere? Edit: Ah, I see, some of the H7's have WWDG and some have WWDG1 |
I think you should be able to just have a single h7_wwdg.yaml and write it like: "WWDG,WWDG?":
... (which is what the G4 WWDG file does:
|
But will that change the bitWidth property as well? That seems important to change... |
I mean, in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
bors merge
Awesome! Thanks for your patience and help :) |
185: Update stm32h7 r=richardeoin a=mattico stm32h7 should have a release soon. Preparing for that. 192: Added interrupt for wwdg r=richardeoin a=diondokter Tested it and it works. It follows the same interrupt pattern and names as the RTC. It took me a while to test because the PAC/SVD has an error it where it says there are only 2 prescaler bits. I was wondering why the timeout came so quickly... :P I'm fixing that here: stm32-rs/stm32-rs#502 Co-authored-by: Matt Ickstadt <mattico8@gmail.com> Co-authored-by: Richard Meadows <962920+richardeoin@users.noreply.github.com> Co-authored-by: Dion Dokter <diondokter@gmail.com>
Fixes #501