Skip to content

Feature/stm32 g4 #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2021
Merged

Feature/stm32 g4 #506

merged 3 commits into from
Mar 21, 2021

Conversation

kevswims
Copy link
Contributor

@kevswims kevswims commented Mar 1, 2021

With these changes I was able to port the USB CDC example from the F3 HAL to the G4.

@github-actions
Copy link

github-actions bot commented Mar 1, 2021

Memory map comparison

kevswims
kevswims commented Mar 11, 2021
View reviewed changes
devices/stm32g473.yaml
@@ -18,3 +18,5 @@ _include:
- ../peripherals/opamp/opamp_g4_common.yaml
- ../peripherals/opamp/opamp_g4_opamp4_5.yaml
- ../peripherals/opamp/opamp_g4_opamp6.yaml
- ./common_patches/rename_USB_FS_peripheral_to_USB.yaml
- ./common_patches/g4_usb.yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these are probably needed for other G4 series as well but I do not have a good way to test those changes. Should they be added?

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@adamgreig
Copy link
Member

Thanks for this PR!

The new BCDR register is good, but it looks like including the rename_USB_FS_peripheral_to_USB.yaml file isn't working, because in this SVD it's called USB_FS_device instead of USB_FS. I think just modifying that file to match against "USB_FS*" instead should do what you want, or you could create a new version to specifically match USB_FS_device.

@kevswims
Copy link
Contributor Author

I'll take a look at that when I'm back from vacation. I thought I had to have that change to get my hal port from the f3 working but I might have changed it in the hal instead or messed something else up along the way.

@github-actions
Copy link

Memory map comparison

@kevswims
Copy link
Contributor Author

@adamgreig I updated this to use the wildcard for the USB renaming. I modified the HAL changes I have for this on the G473 and tested that the USB works.

adamgreig
adamgreig approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 21, 2021

Build succeeded:

@bors bors bot merged commit a7e8163 into stm32-rs:master Mar 21, 2021
@kevswims kevswims deleted the feature/stm32-g4 branch March 21, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevswims @adamgreig
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy