Skip to content

[stm32f7] Fix SYSCFG registers #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2021
Merged

[stm32f7] Fix SYSCFG registers #612

merged 3 commits into from
Sep 9, 2021

Conversation

maximeborges
Copy link
Member

Following #606, fix fields in SYSCFG for every F7 chips

@maximeborges maximeborges mentioned this pull request Sep 1, 2021
Merged
@maximeborges maximeborges changed the title [stm32f7] Fix SYSCFG register [stm32f7] Fix SYSCFG registers Sep 1, 2021
@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Memory map comparison

@maximeborges maximeborges marked this pull request as draft September 1, 2021 17:13
@maximeborges maximeborges marked this pull request as ready for review September 1, 2021 17:22
@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Memory map comparison

@adamgreig adamgreig mentioned this pull request Sep 6, 2021
Closed
10 tasks
@adamgreig
Copy link
Member

Could you rebase this now that the timers PR is merged? It would make it easier to review and to compare the memory maps.

@maximeborges
Copy link
Member Author

Could you rebase this now that the timers PR is merged? It would make it easier to review and to compare the memory maps.

Done.

@github-actions
Copy link

github-actions bot commented Sep 7, 2021

Memory map comparison

@github-actions
Copy link

github-actions bot commented Sep 7, 2021

Memory map comparison

adamgreig
adamgreig reviewed Sep 7, 2021
View reviewed changes
devices/common_patches/f730_f7x2_f7x3_syscfg.yaml Outdated
Comment on lines 3 to 5
_delete:
- PB*
- I2C*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand these deletions, it looks like RM0431 has the I2C and PB fields in PMC, and doesn't have the MII_RMII_SEL? Whereas RM0410 does have MII_RMII_SEL as well as PB and I2C, and only RM0385 (stm32f745, f750, f7x6) has the MII_RMII_SEL but no PB/I2C fields.

Copy link
Member Author

@maximeborges maximeborges Sep 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's me working mainly with the register map and not always checking every register ^^'
Also for RM0431 there is no Ethernet support, so removing MII_RMII_SEL make sense.
d000b9e fix this.
image

For RM0385, I2C seems to support Fast Mode + , so I'm not sure why those fields aren't present here, is the RM wrong?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why 0385 doesn't have them, but they're not in any version of the RM and no mention of it in the errata... I don't have any of those F7 to test with. Maybe ST's HAL has clues? I think we can leave them out for now and add later if it turns out they should be here.

adamgreig
adamgreig reviewed Sep 7, 2021
View reviewed changes
adamgreig
adamgreig requested changes Sep 7, 2021
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks mostly sensible but I didn't totally follow the deletions from the PMC register:

@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Memory map comparison

@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Memory map comparison

adamgreig
adamgreig approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now, thanks. As mentioned in the comment, we can add the FMP fields to 745/750/7x6 (RM0385) later if they do actually exist.

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 9, 2021

Build succeeded:

@bors bors bot merged commit 8f76c26 into stm32-rs:master Sep 9, 2021
bors bot added a commit that referenced this pull request Sep 28, 2021
@bors @maximeborges @adamgreig
Merge #613
a72aca8 
613: [stm32f7] Fix RCC registers r=adamgreig a=maximeborges

Following #612, fix fields  in RCC for every F7 chips

Co-authored-by: Maxime <contact@maximeborg.es>
Co-authored-by: Adam Greig <adam@adamgreig.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximeborges @adamgreig
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy