Readd TIM21/TIM22 to l0xx series #659
Conversation
|
Thanks for this PR, sorry it sat untouched for a while! Is there a reason to not just include |
|
No worries! I'll take a look at implementing your comments tonight if I have time :)
IIRC there were some issues but I don't recall what. I'll try that approach again and comment here if I refresh my memory.
Could you clarify "but that's present on TIM21's OR in the reference manual"? I can't make sense of that statement :/ |
This also removes the CKD from tim21.yaml - this is already included in tim_basic.yaml
| CKD: | ||
| Div1: [0, "t_DTS = t_CK_INT"] | ||
| Div2: [1, "t_DTS = 2 × t_CK_INT"] | ||
| Div4: [2, "t_DTS = 4 × t_CK_INT"] |
There was a problem hiding this comment.
As mentioned in the commit comment, this is already present in tim_basic.yaml. tim21.yaml is only used in tim_l0 currently so I don't think this should cause any issues.
|
Changes made, I'm now using |
This is a partial revert of 0cb0f60 which I believe removed this line in error.
AN4013 Table 3. marks TIM21 and TIM22 as existing for nearly all l0xx devices so I think this PR is correct.
It does however state that TIM22 isn't available on l0x0 devices, but I'm not sure how to approach that change in this repo, so any guidance would be appreciated if we need to add that as a special case. The SVD file appears to have it present for even the l0x0 devices so maybe we don't need to worry about that.
This branch has been tested on a local copy of
stm32l0xx-halwhich compiles with the changes here.