-
Notifications
You must be signed in to change notification settings - Fork 247
STM32H735 yaml fixes #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32H735 yaml fixes #677
Conversation
Thanks for this PR! I'll need a bit of time to review it properly but I can give you some pointers first:
By "block" do you mean in the YAML file or an SVD peripheral? The peripherals probably already exist in the SVD so long as you use the right name. |
Thank you for the tips and positive response. Working on these few definitions in the PR really drove home just how important this crate really is to get anything to work right with these processors, and the amount of work that has already been done to enable this. Unfortunately, I seem to have used the word "block" to mean multiple things, depending on the context. What I meant is that some of the peripheral modifications I included in the PR YAML file, I could not assign to a particular, pre-existing peripheral, and they were thus left commented-out. This is either because:
|
- Added many missing interrupts - Added the CORDIC and FMAC periperals - Resolved a number of naming discrepancies: eg: TIM_CC -> TIM1_CC
436a1cf
to
44b241b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! I've gone through the changes which all look good. I rebased to fix merge conflicts with master and tidied up the yaml file a little (enabled a couple of interrupts, removed some that have since been added separately, removed trailing whitespace, etc).
bors r+
Build succeeded: |
Thank you! Happy to see that it was useful. |
This pull request is related to issue: #670
In this pull request are a bunch of fixes for the STM32H735-family of parts. This mainly concerns the stm32h735.yaml file.
Note: This is my first time (attempting) to contribute to stm32-rs, and there are several TODO's in the code, asking questions. This pull request is likely not good enough as-is.
What it does:
I hope this can be of some use.