Add missing BDCR LSEMOD field for STM32F410/11/12 #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bors merged 1 commit into stm32-rs:master from X-yl:master

Jul 3, 2022

Contributor

X-yl commented Mar 17, 2022

According to this design guide,
https://www.st.com/resource/en/application_note/an2867-oscillator-design-guide-for-stm8afals-stm32-mcus-and-mpus-stmicroelectronics.pdf#page=25,
as well the reference manuals for those MCUs
(https://www.st.com/resource/en/reference_manual/rm0401-stm32f410-advanced-armbased-32bit-mcus-stmicroelectronics.pdf,
https://www.st.com/resource/en/reference_manual/rm0383-stm32f411xce-advanced-armbased-32bit-mcus-stmicroelectronics.pdf,
https://www.st.com/resource/en/reference_manual/rm0402-stm32f412-advanced-armbased-32bit-mcus-stmicroelectronics.pdf)
the LSEMOD bit should be available.

github-actions bot commented Mar 17, 2022

Memory map comparison

newAM added the stm32f4 label

Contributor Author

X-yl commented Mar 18, 2022

Looks like the CI is broken? It failed when installing xmllint? Someone forgot to run sudo apt-get update? :P

Member

richardeoin commented Mar 27, 2022

The CI failure was more than an intermittent problem, indeed we should be running sudo apt-get update in the CI! This is fixed in #709


          Add missing BDCR LSEMOD field for STM32F410/11/12

7968e4c

According to this design guide,
https://www.st.com/resource/en/application_note/an2867-oscillator-design-guide-for-stm8afals-stm32-mcus-and-mpus-stmicroelectronics.pdf#page=25,
as well the reference manuals for those MCUs
(https://www.st.com/resource/en/reference_manual/rm0401-stm32f410-advanced-armbased-32bit-mcus-stmicroelectronics.pdf,
https://www.st.com/resource/en/reference_manual/rm0383-stm32f411xce-advanced-armbased-32bit-mcus-stmicroelectronics.pdf,
https://www.st.com/resource/en/reference_manual/rm0402-stm32f412-advanced-armbased-32bit-mcus-stmicroelectronics.pdf)
the LSEMOD bit should be available.

X-yl force-pushed the master branch from 3fdacc9 to 7968e4c Compare

March 28, 2022 10:11

github-actions bot commented Mar 28, 2022

Memory map comparison

Contributor Author

X-yl commented Mar 28, 2022

The CI failure was more than an intermittent problem, indeed we should be running sudo apt-get update in the CI! This is fixed in #709

Thank you. Just rebased onto master.

adamgreig approved these changes

View reviewed changes

Member

adamgreig left a comment

Thanks!

bors r+

Contributor

bors bot commented Jul 3, 2022

Build succeeded:

CI

bors bot merged commit b49431a into stm32-rs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy