Skip to content

[WIP] Custom Components v2 prototype #11354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 80 commits into
base: develop
Choose a base branch
from
Draft

[WIP] Custom Components v2 prototype #11354

wants to merge 80 commits into from

Conversation

sfc-gh-bnisco
Copy link
Collaborator

Describe your changes

  • Not ready for merge
  • This is a WIP, exploratory branch

GitHub Issue Link (if applicable)

Testing Plan

  • Explanation of why no additional tests are needed
  • Unit Tests (JS and/or Python)
  • E2E Tests
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io Snyk.io
Copy link
Contributor

snyk-io bot commented May 13, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2025 •
edited
Loading

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-11354/streamlit-1.45.1-py3-none-any.whl
🕹️ Preview app pr-11354.streamlit.app (☁️ Deploy here if not accessible)

github-advanced-security[bot]
github-advanced-security bot found potential problems May 13, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems May 13, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2025 •
edited
Loading

📉 Frontend coverage change detected

The frontend unit test (vitest) coverage has decreased by 0.8300%

  • Current PR: 84.9300% (42502 lines, 6402 missed)
  • Latest develop: 85.7600% (42063 lines, 5987 missed)

💡 Consider adding more unit tests to maintain or improve coverage.

📊 View detailed coverage comparison

@sfc-gh-bnisco
Bootstrapping logic
4b4b74f
@sfc-gh-bnisco
New element
83362e5
@sfc-gh-bnisco
Execute JS in BidiComponent
861e415
@sfc-gh-bnisco
Better demo app
804c901
@sfc-gh-bnisco
Fix race conditions
418ce02
@sfc-gh-bnisco
App update
9b3d4c9
@sfc-gh-bnisco
Simplify data-testid
d7592ea
@sfc-gh-bnisco
hooks
a8b6856
@sfc-gh-bnisco
Component Register v2 first pass
3fd5c0d
@sfc-gh-bnisco
Wire up the registry into runtime
377ccb6
@sfc-gh-bnisco
Update API
99d24a1
@sfc-gh-bnisco
Update bidi_component
e054f92
@sfc-gh-bnisco
Enhance component registration to return a callable for creating inst…
f2283db 
…ances of registered bidirectional components
@sfc-gh-bnisco
Get basic.py working again
e125fb2
@sfc-gh-bnisco
Checkpoint for fixing isolated styles
cde91b3
@sfc-gh-bnisco
Refactor
4509271
@sfc-gh-bnisco
Fix potential race condition
72c4e9f
@sfc-gh-bnisco
Add check for existing shadow root in BidiComponent
6c9152a
@sfc-gh-bnisco
Update componentId generation in BidiComponent for improved uniqueness
9cf2b6f
@sfc-gh-bnisco
WIP
ad1c30d
@sfc-gh-bnisco
Fix issue with Shadow DOM load order
9aae21f
@sfc-gh-bnisco
Add frame inspection to component registration for improved error han…
84f3a2f 
…dling
@sfc-gh-bnisco
Move get_bidi_component_registry function to v2 module for better org…
52b8652 
…anization and accessibility
@sfc-gh-bnisco
BidiComponentContext
106ec0d
@sfc-gh-bnisco
Code organization
a0831c9
@sfc-gh-bnisco
Update types
28dd076
@sfc-gh-bnisco
Terser
ef0ed0a
@sfc-gh-bnisco
Test fixes
c3447e4
@sfc-gh-bnisco
JS lint
69ce08e
@sfc-gh-bnisco
Update element mocks
e45554e
@sfc-gh-bnisco
A round of new Ruff rule fixes
41a662b
@sfc-gh-bnisco
Pathing fixes
d8976be
@sfc-gh-bnisco
Revert "Update element mocks"
b4f6f3f 
This reverts commit 066f375.
@sfc-gh-bnisco
Multiple callbacks WIP
d29ee00
@sfc-gh-bnisco
Better example app
95c26d5
@sfc-gh-bnisco
A few quick fixes, still WIP
9de4ee9
@sfc-gh-bnisco
Lint rule updates
c99bed4
@sfc-gh-bnisco
Better exports
39fafa4
@sfc-gh-bnisco
Support fragments
17c49e5
@sfc-gh-bnisco
key -> stKey
1c48831
@sfc-gh-bnisco
Utilize buildBidiComponentURL
bad5a91
@sfc-gh-bnisco
Update to match latest Ruff rules
f82bb78
@sfc-gh-bnisco
Fix up tests
527058a
@sfc-gh-bnisco
backwards compat
873a338
@sfc-gh-bnisco
Raise StreamlitAPIException with improper args
f7a8f4f
@sfc-gh-bnisco
Path fixes
9dcb872
@sfc-gh-bnisco
Tweaks to stabilize the loaded component
861f2b8
@sfc-gh-bnisco
WIP
6192a83
@sfc-gh-bnisco
Fix bug with remounting custom components
4ff52f9
@sfc-gh-bnisco
Terser test
caf05fb
@sfc-gh-bnisco
Update with latest linting rules
91ed21a
@sfc-gh-bnisco
Fix a TODO in the API
65d6130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-bnisco
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy