Skip to content

fix(docs): posible fix broken-navigation #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

WouterBas
Copy link
Contributor

@WouterBas WouterBas commented Jan 8, 2025

Description
This PR resolves the issue with broken navigation on GitHub Pages. I attempted to remove the trailing slash using the Angular Router, but it seems the router does not apply when generating static HTML files for GitHub Pages.

If this feature request every gets implemented, we should follow it's approach.

@WouterBas WouterBas requested a review from WHeirstrate January 8, 2025 13:30
@WouterBas WouterBas self-assigned this Jan 8, 2025
@WouterBas WouterBas linked an issue Jan 8, 2025 that may be closed by this pull request
@IbenTesara IbenTesara added bug Something isn't working documentation Improvements or additions to documentation labels Jan 9, 2025
@IbenTesara IbenTesara added this to the hyperdrive-open-source milestone Jan 9, 2025
@IbenTesara IbenTesara self-requested a review January 9, 2025 07:26
@WouterBas WouterBas merged commit 85f9654 into master Jan 9, 2025
4 checks passed
@WouterBas WouterBas deleted the fix/docs/broken-navigation branch January 9, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documation]: broken navigation
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy