feat: disable default database collector for postgres_exporter #1709
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebengeu
approved these changes
Jul 17, 2025
tgallacher
reviewed
Jul 17, 2025
The database collector emits a metric for the size of each database by default. We emit a metric that represents the sum of all database, which suffices for our purposes. This change removes the redundant per-database metric. In order to avoid a change in the AMI metrics, the change is only made for the QEMU artifact.
|
I'm pretty sure this was inadvertently left out in #788 ("all the collectors are disabled with the additions to the CLI switches in the systemd unit file"). However, out of an abundance of caution, I've updated the PR to only disable it in the QEMU artifact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database collector emits a metric for the size of each database by
default. We emit a metric that represents the sum of all database,
which suffices for our purposes. This change removes the redundant
per-database metric.