Skip to content

fix: ignore route groups when generating typed routes #14050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2025
Merged

fix: ignore route groups when generating typed routes #14050

merged 5 commits into from
Jul 25, 2025

Conversation

dummdidumm
Copy link
Member

Fixes #14043
Fixes #14044

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 1a05576

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm marked this pull request as draft July 25, 2025 11:12
@dummdidumm dummdidumm marked this pull request as ready for review July 25, 2025 11:36
@Conduitry Conduitry changed the title fix: ignore route groupes when generating typed routes fix: ignore route groups when generating typed routes Jul 25, 2025
Conduitry
Conduitry reviewed Jul 25, 2025
View reviewed changes
@dummdidumm dummdidumm merged commit 1cd93cd into main Jul 25, 2025
36 of 38 checks passed
@dummdidumm dummdidumm deleted the typed-route-ids-fix branch July 25, 2025 13:59
@github-actions github-actions bot mentioned this pull request Jul 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conduitry Conduitry Conduitry left review comments

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip (group)s in Pathname/resolve page.url.pathname types are wrong inside layout groups
3 participants
@dummdidumm @Rich-Harris @Conduitry
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy