Skip to content

fix: mark reactions of MAYBE_DIRTY reactions too #16110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

fix: mark reactions of MAYBE_DIRTY reactions too #16110

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
02a30b5
fix: mark reactions of `MAYBE_DIRTY` reactions too
paoloricciuti Jun 8, 2025
20cc0fe
fix: `set_untracked_writes` for `BLOCK_EFFECT`'s too
paoloricciuti Jun 9, 2025
9b3677d
chore: changeset
paoloricciuti Jun 9, 2025
88ad663
Update packages/svelte/src/internal/client/reactivity/sources.js
dummdidumm Jun 10, 2025
863f6c1
Update sources.js
dummdidumm Jun 10, 2025
b7e7034
Merge remote-tracking branch 'origin/main' into derived-reactions-may…
paoloricciuti Jun 10, 2025
7c9c46c
chore: revert
paoloricciuti Jun 10, 2025
42b32c2
Merge remote-tracking branch 'origin/main' into derived-reactions-may…
paoloricciuti Jul 20, 2025
db17c7f
fix: revert to original solution
paoloricciuti Jul 20, 2025
35cdb50
fix: changeset
paoloricciuti Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update sources.js
  • Loading branch information
@dummdidumm
dummdidumm authored Jun 10, 2025
commit 863f6c14b9da6ae24ba399e4f2f73d0081677ec3
2 changes: 1 addition & 1 deletion packages/svelte/src/internal/client/reactivity/sources.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ function mark_reactions(signal, status) {
set_signal_status(reaction, status);

// If the signal a) was previously clean or b) is an unowned derived, then mark it
if ((flags & (CLEAN | UNOWNED)) !== 0) {
if ((flags & (CLEAN | UNOWNED | MAYBE_DIRTY)) !== 0) {
if ((flags & DERIVED) !== 0) {
mark_reactions(/** @type {Derived} */ (reaction), MAYBE_DIRTY);
} else {
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy