Skip to content

fix: append_styles in an effect to make them available on mount #16509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2025
Merged

fix: append_styles in an effect to make them available on mount #16509

merged 2 commits into from
Jul 27, 2025
+90 −11

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Jul 27, 2025 •
edited
Loading

Closes #16472

Small technicality...I'm pretty sure the actual reproduction doesn't work anyway...but that was not working even before. The reason is that the reproduction is missing css inject. However this got me thinking...given that the style tag is meant to be inside the custom element shouldn't we always inject when building a custom element?

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: e006ac5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16509

@Rich-Harris
Copy link
Member

given that the style tag is meant to be inside the custom element shouldn't we always inject when building a custom element?

I think that was the intent:

svelte/packages/svelte/src/compiler/phases/2-analyze/index.js

Lines 503 to 504 in 39ee7cf

custom_element: options.customElementOptions ?? options.customElement,
inject_styles: options.css === 'injected' || options.customElement,

It looks like we forgot to handle the case where customElement is present in <svelte:options> but not in the global compiler config — changing it to this should fix it I think?

-inject_styles: options.css === 'injected' || options.customElement,
+inject_styles: options.css === 'injected' || !!options.customElementOptions || !!options.customElement,

@paoloricciuti
Copy link
Member Author

Yeah it looks like, not at the desk right now so please don't merge, I'll fix this too when I'm back home (unless you beat me to it). I would probably extract custom_element to a variable and use that so that it's always in sync (even tho it's probably unlikely that we change how a custom element is created)

@Rich-Harris
Copy link
Member

pushed a change, will hold off on merging until you've had a chance to review

@paoloricciuti
Copy link
Member Author

pushed a change, will hold off on merging until you've had a chance to review

Looks perfect to me

@paoloricciuti paoloricciuti merged commit 9945205 into main Jul 27, 2025
15 checks passed
@paoloricciuti paoloricciuti deleted the host-access-injected-styles branch July 27, 2025 17:50
@github-actions github-actions bot mentioned this pull request Jul 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$host() styles not synchronously available in onMount and $effect
2 participants
@paoloricciuti @Rich-Harris
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy