feat: async Svelte #725
Merged
feat: async Svelte #725
+22,996
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 003653c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
Pull Request Test Coverage Report for Build 16318899654Details
💛 - Coveralls |
ota-meshi
requested changes
Jul 16, 2025
| "export function tracking(): boolean;", | ||
| "export function root(fn: () => void | (() => void)): () => void;", | ||
| ]); | ||
| break; | ||
| } | ||
| // See https://github.com/sveltejs/svelte/blob/3c4a8d425b8192dc11ea2af256d531c51c37ba5d/packages/svelte/types/index.d.ts#L2997 | ||
| // See https://github.com/sveltejs/svelte/blob/3fa3dd78a1cbaa88a1571977b76bf6f02ed4231d/packages/svelte/types/index.d.ts#L3416 | ||
| case "$props": { | ||
| // Use type parameters to avoid `@typescript-eslint/no-unsafe-assignment` errors. |
There was a problem hiding this comment.
I think the new comment explains it better, so I think this old comment is no longer necessary.
Suggested change
| // Use type parameters to avoid `@typescript-eslint/no-unsafe-assignment` errors. |
|
I will add more tests later. @ota-meshi This PR needs to use ES2022 for top level await, What do you think? Is it ok? Or do we need to use some trick like |
|
ES2024 might be better, that's the ecmaVersion that ESLint v9.0.0 supports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow: sveltejs/svelte#15844, sveltejs/svelte#16376, sveltejs/svelte#16379