bug #61246 [VarDumper] Use unique identifier for RequestContextProvider (ToshY)

nicolas-grekas · nicolas-grekas · commit d157aa720aa1 · 2025-07-29T20:42:12.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [VarDumper] Use unique identifier for `RequestContextProvider` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Issues | Fix #61130  | License | MIT Creates unique identifier for vardumper when running `bin/console server:dump` / `bin/console server:dump --format=html`. The fix in the `RequestContextProvider` now uses `hash('crc32b')` in combination with `$_SERVER['REQUEST_TIME_FLOAT']`, which is the same as the `CliContextProvider`. Commits ------- 73c57e6 Use unique identifier for RequestContextProvider
diff --git a/src/Symfony/Component/VarDumper/Dumper/ContextProvider/CliContextProvider.php b/src/Symfony/Component/VarDumper/Dumper/ContextProvider/CliContextProvider.php
@@ -26,7 +26,7 @@ public function getContext(): ?array
 
         return [
             'command_line' => $commandLine = implode(' ', $_SERVER['argv'] ?? []),
-            'identifier' => hash('crc32b', $commandLine.$_SERVER['REQUEST_TIME_FLOAT']),
+            'identifier' => hash('xxh128', $commandLine.'@'.$_SERVER['REQUEST_TIME_FLOAT']),
         ];
     }
 }
diff --git a/src/Symfony/Component/VarDumper/Dumper/ContextProvider/RequestContextProvider.php b/src/Symfony/Component/VarDumper/Dumper/ContextProvider/RequestContextProvider.php
@@ -45,7 +45,7 @@ public function getContext(): ?array
             'uri' => $request->getUri(),
             'method' => $request->getMethod(),
             'controller' => $controller ? $this->cloner->cloneVar($controller) : $controller,
-            'identifier' => spl_object_hash($request),
+            'identifier' => hash('xxh128', spl_object_id($request).'@'.$_SERVER['REQUEST_TIME_FLOAT']),
         ];
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public function getContext(): ?array`
`26`	`26`
`27`	`27`	`return [`
`28`	`28`	`'command_line' => $commandLine = implode(' ', $_SERVER['argv'] ?? []),`
`29`		`- 'identifier' => hash('crc32b', $commandLine.$_SERVER['REQUEST_TIME_FLOAT']),`
	`29`	`+ 'identifier' => hash('xxh128', $commandLine.'@'.$_SERVER['REQUEST_TIME_FLOAT']),`
`30`	`30`	`];`
`31`	`31`	`}`
`32`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public function getContext(): ?array`
`45`	`45`	`'uri' => $request->getUri(),`
`46`	`46`	`'method' => $request->getMethod(),`
`47`	`47`	`'controller' => $controller ? $this->cloner->cloneVar($controller) : $controller,`
`48`		`- 'identifier' => spl_object_hash($request),`
	`48`	`+ 'identifier' => hash('xxh128', spl_object_id($request).'@'.$_SERVER['REQUEST_TIME_FLOAT']),`
`49`	`49`	`];`
`50`	`50`	`}`
`51`	`51`	`}`