Skip to content

[Filesystem] Fixed a bug in remove() being unable to unlink broken symlinks #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 7, 2012
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Filesystem] Added unit tests for chmod method.
  • Loading branch information
jakzal committed Apr 6, 2012
commit 8071859915aeca7d65afbb44e5c081e8b4a45634
54 changes: 50 additions & 4 deletions src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ public function tearDown()
*/
private function clean($file)
{
if (!file_exists($file)) {
return;
}

if (is_dir($file) && !is_link($file)) {
$dir = new \FilesystemIterator($file);
foreach ($dir as $childFile) {
Expand Down Expand Up @@ -305,4 +301,54 @@ public function testRemoveIgnoresNonExistingFiles()

$this->assertTrue(!is_dir($basePath.'dir'));
}

public function testChmodChangesFileMode()
{
$file = $this->workspace.DIRECTORY_SEPARATOR.'file';
touch($file);

$this->filesystem->chmod($file, 0753);

$this->assertEquals(753, $this->getFilePermisions($file));
}

public function testChmodChangesModeOfArrayOfFiles()
{
$directory = $this->workspace.DIRECTORY_SEPARATOR.'directory';
$file = $this->workspace.DIRECTORY_SEPARATOR.'file';
$files = array($directory, $file);

mkdir($directory);
touch($file);

$this->filesystem->chmod($files, 0753);

$this->assertEquals(753, $this->getFilePermisions($file));
$this->assertEquals(753, $this->getFilePermisions($directory));
}

public function testChmodChangesModeOfTraversableFileObject()
{
$directory = $this->workspace.DIRECTORY_SEPARATOR.'directory';
$file = $this->workspace.DIRECTORY_SEPARATOR.'file';
$files = new \ArrayObject(array($directory, $file));

mkdir($directory);
touch($file);

$this->filesystem->chmod($files, 0753);

$this->assertEquals(753, $this->getFilePermisions($file));
$this->assertEquals(753, $this->getFilePermisions($directory));
}

/**
* Returns file permissions as three digits (i.e. 755)
*
* @return integer
*/
private function getFilePermisions($filePath)
{
return (int) substr(sprintf('%o', fileperms($filePath)), -3);
}
}
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy