Skip to content

[Finder] Exclude relative to content root if prefixed / #54752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: 5.4
Choose a base branch
from
+146 −10
Open

[Finder] Exclude relative to content root if prefixed / #54752

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d685583
fix(Finder): ExcludeDirectoryFilterIterator relative to "root" if `/`
joshtrichards Apr 26, 2024
ca2ca8b
Spacing
joshtrichards Apr 29, 2024
70e0ac4
Add tests for Finder exclude root absolute
joshtrichards May 8, 2024
9f70375
coding standards update
joshtrichards May 8, 2024
6912c9a
add test for absolute underneath a subfolder
joshtrichards May 8, 2024
5b49aa6
additional test adjustments
joshtrichards May 8, 2024
5b47349
add test for sub-root subdir
joshtrichards May 8, 2024
992c48f
fixup: exclude non-root absolute paths since not supported with this …
joshtrichards May 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
coding standards update 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
  • Loading branch information
@joshtrichards
joshtrichards committed May 8, 2024
commit 9f70375a3fa143332bacec3744ed50fd10a987da
2 changes: 1 addition & 1 deletion src/Symfony/Component/Finder/Iterator/ExcludeDirectoryFilterIterator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public function accept()
$path = $this->isDir() ? $this->current()->getRelativePathname() : $this->current()->getRelativePath();
$path = str_replace('\\', '/', $path);
}

if ($this->excludedPattern && preg_match($this->excludedPattern, $path)) {
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Finder/Tests/Iterator/ExcludeDirectoryFilterIteratorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public static function getAcceptData()
'qux_10_2.php',
'qux_12_0.php',
'qux_2_0.php',
];
];

$foo_absolute_root = [
'.bar',
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy