Skip to content

[Serializer] Fix collect_denormalization_errors flag in defaultContext #60413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dmbrson
Copy link
Contributor

@dmbrson dmbrson commented May 13, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #59721
License MIT

When using the COLLECT_DENORMALIZATION_ERRORS flag during denormalization, Symfony should collect all errors and report them together in a PartialDenormalizationException.

Here is an example with two expected errors:

final readonly class Foo
{
    public function __construct(
        public string $bar,
        public \DateTimeInterface $createdAt,
    ) {}
}

$foo = $this->denormalizer->denormalize(
    data: ['createdAt' => ''],
    type: Foo::class,
);

Expected errors

  1. Failed to create object because the class misses the "bar" property.
  2. The data is either not a string, an empty string, or null; you should pass a string that can be parsed with the passed format or a valid DateTime string.

When the flag is passed via the context

$foo = $this->denormalizer->denormalize(
    data: ['createdAt' => ''],
    type: Foo::class,
    context: [
        DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS => true,
    ],
);

Both errors are correctly collected and returned.

When the flag is set via default_context in framework.yaml:

serializer:
    default_context:
        collect_denormalization_errors: true

Only one error is returned:
The data is either not a string, an empty string, or null; you should pass a string that can be parsed with the passed format or a valid DateTime string.

#Root Cause
The issue originates in the \src\Symfony\Component\Serializer\Serializer.php,
function normalize :

if (isset($context[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS]) || isset($this->defaultContext[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS])) {
    unset($context[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS]);
    $context['not_normalizable_value_exceptions'] = [];
    $errors = &$context['not_normalizable_value_exceptions'];
    $denormalized = $normalizer->denormalize($data, $type, $format, $context);
}

The first time this block is hit, it checks for the flag either in $context or $defaultContext. If found, it initializes the error array with:

    $context['not_normalizable_value_exceptions'] = [];

However, during nested denormalization (e.g., when parsing the createdAt field), Symfony re-enters this code path. If the flag was provided via defaultContext, it is still present on re-entry. Therefore, the not_normalizable_value_exceptions array is reset again, losing the previously collected errors.

#My Fix

The fix is to enhance the condition with an additional check to ensure the array of errors is not already initialized:

if (
    (isset($context[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS]) || isset($this->defaultContext[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS]))
    && !isset($context['not_normalizable_value_exceptions'])
)

This ensures the array is only initialized once, preserving previously collected errors in recursive calls, regardless of whether the flag was passed via context or default_context.

@dmbrson dmbrson requested a review from dunglas as a code owner May 13, 2025 14:34
@carsonbot carsonbot added this to the 6.4 milestone May 13, 2025
@symfony symfony deleted a comment from carsonbot Jun 27, 2025
@nicolas-grekas nicolas-grekas force-pushed the fix_59721_collect_denormalization_flag branch from afc84f3 to d4a71ee Compare June 27, 2025 15:34
@nicolas-grekas
Copy link
Member

Thank you @dmbrson.

@nicolas-grekas nicolas-grekas merged commit a880ecb into symfony:6.4 Jun 27, 2025
9 of 11 checks passed
This was referenced Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy