Skip to content

[HttpFoundation] Revert " Emit PHP warning when Response::sendHeaders() is called while output has already been sent" #60875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 7.3
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #60603
License MIT

This reverts commit cf554e1, reversing changes made to 392d0c9.

Let's revert as this change is too disruptive for a minor version (and I'm also going to replace this by a deprecation on 7.4 so that we can throw the warning in 8.0)

…esponse::sendHeaders()` is called while output has already been sent (ivo95v)"

This reverts commit cf554e1, reversing
changes made to 392d0c9.
@carsonbot carsonbot added this to the 7.3 milestone Jun 23, 2025
@carsonbot carsonbot changed the title Revert "[HttpFoundation] Emit PHP warning when Response::sendHeaders() is called while output has already been sent" [HttpFoundation] Revert " Emit PHP warning when Response::sendHeaders() is called while output has already been sent" Jun 23, 2025
@nicolas-grekas nicolas-grekas merged commit ecb09ea into symfony:7.3 Jun 23, 2025
10 of 11 checks passed
nicolas-grekas added a commit that referenced this pull request Jun 23, 2025
…()` after headers have already been sent (nicolas-grekas)

This PR was merged into the 7.4 branch.

Discussion
----------

[HttpFoundation] Deprecate using `Request::sendHeaders()` after headers have already been sent

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Sibling to #60875 to account for #60603

Commits
-------

6f6fdf0 [HttpFoundation] Deprecate using `Request::sendHeaders()` after headers have already been sent
@nicolas-grekas nicolas-grekas deleted the hf-header-revert-warning branch June 24, 2025 06:19
@robert-stanciu
Copy link

When will this be released?

@fabpot fabpot mentioned this pull request Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy