Skip to content

Fix implicit to and from bool type juggling #60890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 30 commits into
base: 7.4
Choose a base branch
from
Open

Fix implicit to and from bool type juggling #60890

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d7109ac
Pull fixes from Nicolas
Girgias Jun 24, 2025
4212ed9
Pull ignores/suppressed tests from Nicolas
Girgias Jun 24, 2025
90c0a98
Use false instead of 0
Girgias Jun 24, 2025
d0834ee
IntlTestHelper::requireFullIntl() use null as second arg instead of f…
Girgias Jun 24, 2025
d387c49
Check return value of getenv()
Girgias Jun 24, 2025
ad4fd82
Symfony\Component\Validator\Constraints\Isbn does not take a bool as …
Girgias Jun 24, 2025
2ee80c5
intl false instead of null
Girgias Jun 25, 2025
6190e42
Cast result of preg_match to bool
Girgias Jun 24, 2025
9997d96
Use bool as param type
Girgias Jun 24, 2025
78f4f10
Cast bitwise op result to bool
Girgias Jun 24, 2025
de4c7d5
ErrorHandler::handleError() cast bitwise op to bool and use false ins…
Girgias Jun 24, 2025
17ab127
Yield empty string when no doc comment exists
Girgias Jun 24, 2025
f677c74
Set value to null if parse_url() fails badly and returns false
Girgias Jun 24, 2025
90401c0
Fix deprecation with PHPUnit's assertTrue
Girgias Jun 24, 2025
85de1ec
Remove ZPP test
Girgias Jun 24, 2025
72b9650
file_get_contents() does not take a fopen mode parameter
Girgias Jun 24, 2025
aa67b63
Symfony\Component\String\LazyString::resolve() add explicit string cast
Girgias Jun 24, 2025
2317f30
Fix string to true type juggling in test
Girgias Jun 24, 2025
4edbb43
Remove ZPP test
Girgias Jun 24, 2025
2017a7b
Use empty string instead of false
Girgias Jun 24, 2025
e816540
Explicit cast to bool from string
Girgias Jun 25, 2025
8afc277
Definition::addMethodCall() arg 3 must be a bool v2
Girgias Jun 25, 2025
4d883cc
Fix test passing false to ?string type
Girgias Jun 29, 2025
218a4f8
Remove ZPP tests testing false to string coercion
Girgias Jun 29, 2025
5397577
NumberFormatter::setAttribute() takes values of type int|float
Girgias Jun 29, 2025
dfcef56
Default non-existing environment variable to empty string
Girgias Jun 29, 2025
a828919
Split grapheme extraction and check if one is found
Girgias Jun 29, 2025
52dec0e
Fix substr with bool?
Girgias Jun 29, 2025
f3286e3
Use '1' instead of true
Girgias Jun 29, 2025
fa063a6
cookie_httponly key does not support values of auto
Girgias Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pull ignores/suppressed tests from Nicolas
  • Loading branch information
@Girgias
Girgias committed Jun 27, 2025
commit 4212ed9331fac5b09895bfe94e31f259fe0723a7
2 changes: 1 addition & 1 deletion src/Symfony/Component/DependencyInjection/Tests/AliasTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public static function invalidDeprecationMessageProvider(): array
"With \ns" => ["invalid \n message %alias_id%"],
'With */s' => ['invalid */ message %alias_id%'],
'message not containing required %alias_id% variable' => ['this is deprecated'],
'template not containing required %alias_id% variable' => [true],
//'template not containing required %alias_id% variable' => [true],
];
}
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckTypeDeclarationsPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ public function testProcessFailsOnPassingClassToScalarTypedParameter()
(new CheckTypeDeclarationsPass(true))->process($container);
}

public function testProcessSuccessOnPassingBadScalarType()
public function xtestProcessSuccessOnPassingBadScalarType()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why skipping this test ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stole this from @nicolas-grekas WIP commit: nicolas-grekas@02e3881

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

{
$container = new ContainerBuilder();

Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/DependencyInjection/Tests/DefinitionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ public static function invalidDeprecationMessageProvider(): array
"With \ns" => ["invalid \n message %service_id%"],
'With */s' => ['invalid */ message %service_id%'],
'message not containing require %service_id% variable' => ['this is deprecated'],
'template not containing require %service_id% variable' => [true],
//'template not containing require %service_id% variable' => [true],
];
}

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy