[SecurityBundle] Remove deprecated OIDC token handler options algorithm and key
#60929
+26
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Jun 27, 2025
| Q | A |
|---|---|
| Branch? | 8.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | -- |
| License | MIT |
OskarStark
commented
Jun 27, 2025
Comment on lines
+95
to
+96
| ->ifTrue(static fn ($v) => !isset($v['algorithms'])) | ||
| ->thenInvalid('You must set "algorithms".') |
There was a problem hiding this comment.
I think this can be removed, right? As algorithms is marked with isRequired()
There was a problem hiding this comment.
I think so yes
you might want to verify on a proto app of course
d4eb6c2 to
3b3362f
Compare
…hm and key Remove the deprecated algorithm and key options from the OIDC token handler configuration, use algorithms and keyset instead. - Add CHANGELOG entry - Add UPGRADE-8.0.md entry with before/after examples - Remove legacy test for deprecated options - No need to remove symfony/deprecation-contracts (not present)
3b3362f to
3ae1f9f
Compare
Comment on lines
+339
to
+350
| # config/packages/security.yaml | ||
| security: | ||
| firewalls: | ||
| main: | ||
| access_token: | ||
| token_handler: | ||
| oidc: | ||
| - algorithm: 'RS256' | ||
| - key: 'https://example.com/.well-known/jwks.json' | ||
| + algorithms: ['RS256'] | ||
| + keyset: 'https://example.com/.well-known/jwks.json' | ||
| ``` |
There was a problem hiding this comment.
in a diff, non modified lines must start with an extra space (instead of a + / - for changed lines):
Suggested change
| # config/packages/security.yaml | |
| security: | |
| firewalls: | |
| main: | |
| access_token: | |
| token_handler: | |
| oidc: | |
| - algorithm: 'RS256' | |
| - key: 'https://example.com/.well-known/jwks.json' | |
| + algorithms: ['RS256'] | |
| + keyset: 'https://example.com/.well-known/jwks.json' | |
| ``` | |
| # config/packages/security.yaml | |
| security: | |
| firewalls: | |
| main: | |
| access_token: | |
| token_handler: | |
| oidc: | |
| - algorithm: 'RS256' | |
| - key: 'https://example.com/.well-known/jwks.json' | |
| + algorithms: ['RS256'] | |
| + keyset: 'https://example.com/.well-known/jwks.json' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.