-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Validator] Add SemVer
constraint for semantic versioning validation
#60995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+592
−0
Closed
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
74b2af6
[Validator] Add SemVer constraint for semantic versioning validation
OskarStark 5a1aa4a
Add newlines at EOF and improve code formatting
OskarStark 2ac6a74
Import DataProvider attribute and use short syntax
OskarStark 1e3e416
fix
OskarStark bf610d8
-
OskarStark 94fd2ac
Fix SemVer validation pattern and tests
OskarStark 949d5e9
Simplify SemVer constraint to use single 'strict' option
OskarStark c287e8d
Update src/Symfony/Component/Validator/Constraints/SemVerValidator.php
OskarStark 4e5ec8b
Change default value of strict option to true
OskarStark a1e9e3a
Remove array-based configuration support from SemVer constraint
OskarStark 980da3b
Remove unnecessary comment
OskarStark 24ae6af
Use x modifier for regex patterns to improve readability
OskarStark 29fa35a
Apply stof's suggestions for better compatibility
OskarStark a1150a8
Apply suggestions from code review
OskarStark 16a50f5
Update src/Symfony/Component/Validator/Constraints/SemVer.php
OskarStark eb7cb3a
Add min/max version constraints to SemVer validator
OskarStark c662126
Rename tooHighMessage/tooLowMessage to minMessage/maxMessage and make…
OskarStark b944f69
Update src/Symfony/Component/Validator/Tests/Constraints/SemVerValida…
OskarStark 2481bab
Move expectException calls directly before the code that triggers the…
OskarStark ccf6364
Add tests for custom message, minMessage and maxMessage
OskarStark 5fc3119
Follow Symfony constraint pattern: initialize message properties with…
OskarStark 7b2c9d2
Update src/Symfony/Component/Validator/Tests/Constraints/SemVerValida…
OskarStark dd3a772
Update src/Symfony/Component/Validator/Tests/Constraints/SemVerValida…
OskarStark bcd66da
Remove unnecessary comments as requested in code review
OskarStark f87dff0
Apply code review feedback from fabpot and nicolas-grekas
OskarStark 2af8ece
Add documentation for SemVer constraint options
OskarStark 8d04e1e
Refactor SemVer constraint to use non-nullable constructor arguments
OskarStark 09dbe1c
Fix parameter order: keep nullable parameters at the end
OskarStark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove unnecessary comments as requested in code review
As per Alex Daubois's review comments, removed explanatory comments that were deemed unnecessary for clean, self-documenting code.
- Loading branch information
commit bcd66da700d61e28d285c657b4be1a56fee332ac
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.