[JsonStreamer] Fix nested generated foreach loops #61001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mttsch
commented
Jul 1, 2025
| Q | A |
|---|---|
| Branch? | 7.3 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #60984 |
| License | MIT |
mttsch
commented
Jul 1, 2025
src/Symfony/Component/JsonStreamer/Tests/Fixtures/stream_writer/nullable_object_dict.php
Outdated
Show resolved
Hide resolved
mtarld
requested changes
Jul 1, 2025
src/Symfony/Component/JsonStreamer/Write/StreamWriterGenerator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/JsonStreamer/Tests/Fixtures/stream_writer/nullable_object_dict.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/JsonStreamer/Tests/Fixtures/Model/JsonStreamableDummy.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/JsonStreamer/Tests/Fixtures/Model/DummyWithNestedArray.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/JsonStreamer/Tests/Fixtures/Model/DummyWithArray.php
Outdated
Show resolved
Hide resolved
769c229 to
89887a8
Compare
|
@mtarld Except for the constructor property promotion comment (see my response above), your notes have been implemented. |
mtarld
reviewed
Jul 1, 2025
src/Symfony/Component/JsonStreamer/DataModel/Write/CollectionNode.php
Outdated
Show resolved
Hide resolved
89887a8 to
6c97b1d
Compare
mtarld
approved these changes
Jul 1, 2025
|
Thank you @mttsch. |
mtarld
added a commit
to mtarld/symfony
that referenced
this pull request
Jul 7, 2025
nicolas-grekas
added a commit
that referenced
this pull request
Jul 7, 2025
* 7.4: [HttpKernel] Avoid memory leaks cache attribute, profiler listener [JsonStreamer] Upmerge #61001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.