Skip to content

[Security] Remove deprecated RememberMeToken::getSecret() #61011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

[Security] Remove deprecated RememberMeToken::getSecret() #61011

merged 1 commit into from
Jul 8, 2025

Conversation

ktherage
Copy link
Contributor

@ktherage ktherage commented Jul 1, 2025 •
edited by alexandre-daubois
Loading

Q A
Branch? 8.0
Bug fix? no
New feature? yes
Deprecations? no
Issues --
License MIT

@ktherage ktherage requested a review from chalasr as a code owner July 1, 2025 09:44
@carsonbot carsonbot added this to the 8.0 milestone Jul 1, 2025
@ktherage ktherage changed the title [Security] Removal deprecated RememberMeToken::getSecret() and RememberMeToken's secret property [Security] Removal deprecated RememberMeToken::getSecret() and RememberMeToken's $secret property Jul 1, 2025
@ktherage ktherage force-pushed the RememberMeToken-bc-layer-removal branch 2 times, most recently from 002f9c9 to 63e71e7 Compare July 1, 2025 13:33
@alexandre-daubois alexandre-daubois changed the title [Security] Removal deprecated RememberMeToken::getSecret() and RememberMeToken's $secret property [Security] Remove deprecated RememberMeToken::getSecret() and RememberMeToken's $secret property Jul 2, 2025
alexandre-daubois
alexandre-daubois approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@alexandre-daubois alexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the discussion with Oskar is resolved 🙂

@welcoMattic welcoMattic added the BC Layer removal Used to track BC layer removals before a major release label Jul 4, 2025
xabbuh
xabbuh requested changes Jul 6, 2025
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the constructor of the RememberMeAuthenticator class also has to be updated

@ktherage
Copy link
Contributor Author

ktherage commented Jul 7, 2025

I think the constructor of the RememberMeAuthenticator class also has to be updated

In which way ? I've removed the deprecation notice there : https://github.com/symfony/symfony/pull/61011/files#diff-8cdcb3fe63f51aca31c4a5869e39ffdfcc793d9d855df4498528a56e1bbd32cdL35-L39.

Is there something I missed updating this ?

@xabbuh
Copy link
Member

xabbuh commented Jul 7, 2025

@ktherage That's the token, but there also is an authenticator class.

@ktherage ktherage force-pushed the RememberMeToken-bc-layer-removal branch from 799ce91 to 9767a2a Compare July 7, 2025 09:38
@ktherage
Copy link
Contributor Author

ktherage commented Jul 7, 2025

@xabbuh I did it and rebased. Sorry for this forgetfulness.

fabpot
fabpot requested changes Jul 8, 2025
View reviewed changes
@nicolas-grekas nicolas-grekas changed the title [Security] Remove deprecated RememberMeToken::getSecret() and RememberMeToken's $secret property [Security] Remove deprecated RememberMeToken::getSecret() Jul 8, 2025
@nicolas-grekas nicolas-grekas force-pushed the RememberMeToken-bc-layer-removal branch from 9767a2a to 6b614c5 Compare July 8, 2025 09:41
nicolas-grekas
nicolas-grekas approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the missing UPGRADE + CHANGELOG files updates + simplified the serialization logic.

@nicolas-grekas nicolas-grekas force-pushed the RememberMeToken-bc-layer-removal branch from 6b614c5 to a844f14 Compare July 8, 2025 10:27
@nicolas-grekas nicolas-grekas force-pushed the RememberMeToken-bc-layer-removal branch from a844f14 to 2fea866 Compare July 8, 2025 10:30
@nicolas-grekas
Copy link
Member

Thank you @ktherage.

@nicolas-grekas nicolas-grekas merged commit d1d33e2 into symfony:8.0 Jul 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@welcoMattic welcoMattic welcoMattic left review comments

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot requested changes

@xabbuh xabbuh xabbuh requested changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
BC Layer removal Used to track BC layer removals before a major release Security Status: Reviewed
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
9 participants
@ktherage @xabbuh @nicolas-grekas @fabpot @stof @welcoMattic @OskarStark @alexandre-daubois @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy