Skip to content

Fix php.net links #61037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Fix php.net links #61037

merged 1 commit into from
Jul 7, 2025

Conversation

benjaminpick
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

When the paramter 'interval' contains an invalid relative date string, the exception message shows an invalid URL.
This PR fixes the URLs.

@carsonbot carsonbot added this to the 6.4 milestone Jul 4, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

GromNaN
GromNaN reviewed Jul 4, 2025
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @benjaminpick for your valuable contribution.

I think we can even improve by using the "short" link. It has the benefit of being displayed automatically in the user's language.

@nicolas-grekas nicolas-grekas changed the title [RateLimiter] Fix php.net links in $intervalNormalizer Fix php.net links Jul 7, 2025
@nicolas-grekas nicolas-grekas force-pushed the benjaminpick-patch-1 branch from d40c036 to 26183e3 Compare July 7, 2025 06:45
@nicolas-grekas
Copy link
Member

Thank you @benjaminpick.

@nicolas-grekas nicolas-grekas merged commit 093dd11 into symfony:6.4 Jul 7, 2025
11 checks passed
@alexander-schranz alexander-schranz mentioned this pull request Jul 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN left review comments

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@benjaminpick @carsonbot @nicolas-grekas @GromNaN
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy