Skip to content

[Form] Skip windows x86 number transformer test #61055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

[Form] Skip windows x86 number transformer test #61055

merged 1 commit into from
Jul 7, 2025

Conversation

OskarStark
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues #60975
License MIT

Follows #60975 (comment)

@OskarStark OskarStark requested review from xabbuh and yceruto as code owners July 7, 2025 10:42
@carsonbot

This comment was marked as outdated.

Sign in to view
@carsonbot carsonbot added this to the 7.4 milestone Jul 7, 2025
@OskarStark OskarStark changed the base branch from 7.4 to 6.4 July 7, 2025 10:42
@OskarStark OskarStark modified the milestones: 7.4, 6.4 Jul 7, 2025
@OskarStark OskarStark mentioned this pull request Jul 7, 2025
Merged
@OskarStark
Copy link
Contributor Author

OskarStark commented Jul 7, 2025 •
edited
Loading

Hmm, seems that the 32bit number is now to low to not be rounded.

1) Symfony\Component\Form\Tests\Extension\Core\DataTransformer\NumberToLocalizedStringTransformerTest::testReverseTransformDoesNotCauseIntegerPrecisionLoss
Failed asserting that 2147483646.0 is identical to 2147483646.

any idea? @xabbuh shall we just skip this test on 32bit?

@OskarStark OskarStark changed the title [Form] Fix windows x86 number transformer test [Form] Skip windows x86 number transformer test Jul 7, 2025
@OskarStark OskarStark force-pushed the fix-windows-x86-number-transformer-test branch from 4d58ecc to ba28b51 Compare July 7, 2025 11:53
@OskarStark
Copy link
Contributor Author

ready to merge

@nicolas-grekas nicolas-grekas force-pushed the fix-windows-x86-number-transformer-test branch from d9b603a to a426cdd Compare July 7, 2025 12:41
@nicolas-grekas
Copy link
Member

Thank you @OskarStark.

@nicolas-grekas nicolas-grekas merged commit 7d1b50a into symfony:6.4 Jul 7, 2025
10 of 11 checks passed
@OskarStark OskarStark deleted the fix-windows-x86-number-transformer-test branch July 7, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@OskarStark @carsonbot @nicolas-grekas @stof
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy