[Validator] Allow mixed root on CompoundConstraintTestCase validator
#61056
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
8af9986 to
47b5387
Compare
I rebased this PR on the 7.2 branch |
nicolas-grekas
approved these changes
Jul 8, 2025
CompoundConstraintTestCase validator
alexandre-daubois
approved these changes
Jul 9, 2025
|
Thank you @thePanz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CompoundConstraintTestCase is currently defining a
protected string $root, forcing the root to be a "string".Testing compound constraints where the root is something different is triggering Static-Analysis (phpstan) warings or (worst) casting the
$rootto a string, causing PHP errors.In the given code: the
$rootis passed to the ExecutionContext, which has the following constructor signature:__construct(private ValidatorInterface $validator, private mixed $root, private TranslatorInterface $translator, ...), thusmixedcan be safely used in theCompoundConstraintTestCaseclass too.