[Brevo Mailer] Webhook IP Addresses have changed #61062
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 for bug fix". Cheers! Carsonbot |
fabpot
approved these changes
Jul 8, 2025
|
Thank you @richardhj. |
xabbuh
reviewed
Jul 8, 2025
| @@ -37,7 +37,7 @@ protected function getRequestMatcher(): RequestMatcherInterface | |||
| new IsJsonRequestMatcher(), | |||
| // https://developers.brevo.com/docs/how-to-use-webhooks#securing-your-webhooks | |||
| // localhost is added for testing | |||
| new IpsRequestMatcher(['185.107.232.1/24', '1.179.112.1/20', '127.0.0.1']), | |||
| new IpsRequestMatcher(['185.107.232.1/24', '1.179.112.1/20', '172.246.240.1/20', '127.0.0.1']), | |||
There was a problem hiding this comment.
Is the 185.107.232.1/24 range still valid? I cannot find it in the linked document.
There was a problem hiding this comment.
You might be right and we can remove the first one. But I thought they might have legacy services running, so this was the most cautious approach.
There was a problem hiding this comment.
At least in my environment I don't find 185.107.xxx requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So first I recognized multiple
RejectWebhookExceptions. Then I checked my access logs and realized that webhook from Brevo can also come from the '172.246.240.1/20' IP range.This is also documented here: https://help.brevo.com/hc/en-us/articles/15127404548498-Brevo-IP-ranges-List-of-publicly-exposed-services
This new IP range must have been added later this year, it hasn't been there in January, for instance: https://web.archive.org/web/20250125161029/https://help.brevo.com/hc/en-us/articles/15127404548498-Brevo-IP-ranges-List-of-publicly-exposed-services
So this PR adds the new IP range for ingress webhook validation.