Various CS fixes #61064
Merged
Various CS fixes #61064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jul 8, 2025
| @@ -1462,7 +1462,7 @@ public function registerAttributeForAutoconfiguration(string $attributeClass, ca | |||
| * | |||
| * @param ?string $target | |||
| */ | |||
| public function registerAliasForArgument(string $id, string $type, ?string $name = null/*, ?string $target = null */): Alias | |||
| public function registerAliasForArgument(string $id, string $type, ?string $name = null/* , ?string $target = null */): Alias | |||
There was a problem hiding this comment.
php-cs-fixer has a rule requiring whitespace around the comment text, which is why this is added. This rule makes sense for normal comments. For such comments containing future code changes, it might be a bit weird but that's still fine and we'll fix the coding standards anyway when replacing the comment with code (we already had a trailing space that won't be present in the replaced code either)
stof
reviewed
Jul 8, 2025
| @@ -113,7 +113,7 @@ private function processDefinition(ContainerBuilder $container, string $id, Defi | |||
| $definition = substr_replace($definition, 'Child', 44, 0); | |||
| } | |||
| $definition = unserialize($definition); | |||
| /** @var ChildDefinition $definition */ | |||
| /* @var ChildDefinition $definition */ | |||
There was a problem hiding this comment.
this looks weird. I think this should be solved by putting the @var phpdoc on the assignment statement instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running latest php-cs-fixer