[ExpressionLanguage] Fix dumping of null safe operator #61076
Merged
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Jul 9, 2025
Spomky
approved these changes
Jul 9, 2025
fabpot
approved these changes
Jul 10, 2025
|
Thank you @ivantsepp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when you dump an expression that uses null safe operator, the returned string doesn't maintain the null safe operator.
I would have expected
user?.footo be returned instead.(I've also fixed some test data providers cases -
getDumpDataprovider should only generate cases with 2 elements but some tests are including a third argument. So I went ahead and removed them)