[Config] Add support for enums in ReflectionClassResource
#61079
+68
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d42a3e3 to
230a888
Compare
230a888 to
b3f6c68
Compare
ReflectionClassResource
OskarStark
reviewed
Jul 9, 2025
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
GromNaN
reviewed
Jul 9, 2025
I have a compiler that creates PHP code based on some classes and enums I declare in my application. I use the resources to quickly check if there are changes and if I should recompile. To be specific: it's creating Webonyx GraphQL type files, which are annoying to create by hand (arrays etc). Therefore we have our own abstraction with attributes. |
|
@GromNaN that is a valid use case for these classes, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using ReflectionClassResource in a project to track changes of files. I noticed that attributes on enum cases were not tracked properly. The cases were visible, because the enum cases are available as class constants.
But the attributes were missing.
This solves the problem.
Not sure if we should see this as a bug or feature. I think it's a bug.