Skip to content

[Validator] Add missing Polish plural form for filename length validator #61083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2025
Merged

[Validator] Add missing Polish plural form for filename length validator #61083

merged 1 commit into from
Jul 10, 2025
+1 −1

Conversation

czachor
Copy link
Contributor

@czachor czachor commented Jul 9, 2025

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues None
License MIT

Fixed the Polish translation for filename length validation message by adding all three required plural forms (instead of two).

Problem:
Locale set to pl. If the validation Symfony\Component\Validator\Constraints\File was triggered for the example configuration:

new File([
    'filenameMaxLength' => 100,
])

the exception SymfonyComponentTranslationExceptionInvalidArgumentException is thrown if the file name exceeds 100 characters. The exact message is:

Unable to choose a translation for "Nazwa pliku jest za długa. Powinna mieć {{ filename_max_length }} znak lub mniej.|Nazwa pliku jest za długa. Powinna mieć {{ filename_max_length }} znaków lub mniej." with locale "pl" for value "100". Double check that this translation has the correct plural options (e.g. "There is one apple|There are %count% apples").

The cause is a missing third plural form: the original translation contained only two forms.

@czachor
[Validator] Add missing Polish plural form for filename length validator
f4514d7 
Fixed the Polish translation for filename length validation message by adding all three required plural forms (instead of two).
@carsonbot carsonbot added this to the 7.4 milestone Jul 9, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "6.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@czachor czachor changed the base branch from 7.4 to 6.4 July 9, 2025 20:14
@fabpot fabpot modified the milestones: 7.4, 6.4 Jul 10, 2025
@fabpot
Copy link
Member

fabpot commented Jul 10, 2025

Thank you @czachor.

@fabpot fabpot merged commit 50e39b8 into symfony:6.4 Jul 10, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@czachor @carsonbot @fabpot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy