Skip to content

[Routing] Add test to validate that default value is allowed to not match requirement #61094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 6.4
Choose a base branch
from
Open

[Routing] Add test to validate that default value is allowed to not match requirement #61094

wants to merge 3 commits into from
+24 −0

Conversation

tcoch
Copy link
Contributor

@tcoch tcoch commented Jul 10, 2025 •
edited by OskarStark
Loading

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues #61022
License MIT

Suppose you have this route definition:

$route = new Route('/test/{foo}', ['foo' => 'foo-'], ['foo' => '\w+'], []);

With this route definition:

  • /test/foo works
  • /test/foo- fails, because the dash is not permitted by the requirement
  • /test works, thanks to the default value. However, the value of the parameter foo does not meet the requirement.

@carsonbot carsonbot added this to the 6.4 milestone Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Routing Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
2 participants
@tcoch @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy