Fix various to/from bool type coercions #61103
Open
+40
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the coding style of the isMagicCallEnabled() method.
This comment has been minimized.
This comment has been minimized.
stof
reviewed
Jul 11, 2025
| @@ -85,7 +85,7 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed | |||
| $setters = $value->getMethodCalls(); | |||
| $value->setMethodCalls($withers); | |||
| foreach ($setters as $call) { | |||
| $value->addMethodCall($call[0], $call[1], $call[2] ?? false); | |||
| $value->addMethodCall($call[0], $call[1], isset($call[2]) && $call[2]); | |||
There was a problem hiding this comment.
I would not change that, as we expect the third array value to be a boolean. Instead, we should fix the invalid usages of the method calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cherry-picking some of the commits from #60890 which are basically bugs.
Not sure what the commit naming policy is so do let me know if you want me to manually rebase and rename commits following some guidelines.